Skip to content

Implemented getDefaultField and getDefaultValue props #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2020
Merged

Implemented getDefaultField and getDefaultValue props #157

merged 3 commits into from
Oct 4, 2020

Conversation

jakeboone02
Copy link
Member

@jakeboone02 jakeboone02 commented Oct 1, 2020 •
edited
Loading

This PR introduces the getDefaultField and getDefaultValue props.

Fixes #156.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020 •
edited
Loading

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #157   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          281       285    +4     
  Branches        73        76    +3     
=========================================
+ Hits           281       285    +4
Impacted Files Coverage Δ
src/QueryBuilder.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6562329...9de4f26. Read the comment docs.

@jakeboone02 jakeboone02 mentioned this pull request Oct 1, 2020
Closed
@saurabhnemade
Copy link
Contributor

Looks good. 👍

@jakeboone02 jakeboone02 changed the title Implemented defaultField and defaultValue props Implemented getDefaultField and getDefaultValue props Oct 4, 2020
@jakeboone02 jakeboone02 merged commit 87618b7 into master Oct 4, 2020
@jakeboone02 jakeboone02 deleted the default-field-default-value branch October 4, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

on rule add its selecting first value
3 participants
@jakeboone02 @codecov-commenter @saurabhnemade