-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Closed
Description
Migrated from facebook/react/issues/8063
Coordinate with docs translators via @ericnakagawa
This issue involves multiple steps:
- Integrate with to download localized contentGenerate localized URLs using said contentAutomatically sync English content changes from GitHub to Crowdin (see and )Maintain backwards compatibility for all current (non-localized, English) linksAdd localization toggle to headerUpdate the "" link to point to GitHub for English pages and Crowdin for other languages.To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
Integrate with Crowdin
This could be done via a custom Gatsby plug-in. We've already written a couple. (It would be nice to work with @KyleAMathews to share this plug-in back with Gatsby so that other users could benefit from it as well.)
If we run into any performance problems, @ericnakagawa has volunteered to work with Netlify and Crowdin to simplify or speed up this syncing process. Ideally this sync process will be fast enough to allow Netlify's PR previews to also be used to test localized builds of the site.
Misc thoughts and questions
- In the case of non-localized content, Crowdin serves English as fallback.
- How can site consume list of active locales? Is there a Crowdin API?
- How does this impact urls (eg
/docs/<file>
,/docs/<lang>/<file>
)?
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
KyleAMathews commentedon Oct 9, 2017
Happy to help create a Gatsby source plugin for Crowdin! That'd be really powerful. And a lot of people would use it including sooner than later gatsbyjs.org
From a bit of research, it looks like it'd be pretty easy to pull data using their API:
I spent a bunch of time adding localization support to https://www.gatsbyjs.org/packages/gatsby-source-contentful/ as well so have some opinions on this. See the example site for Contentful + its source
bvaughn commentedon Oct 9, 2017
Fantastic 😄 There's a good chance we'll end up collaborating on this soon then.
Daniel15 commentedon Oct 18, 2017
Netlify also has a way of doing redirects based on
Accept-Language
header and GeoIP. For example, if someone from Italy (or someone with their browser or OS set to request Italian content) visits the home page and they don't have a language cookie already set, we can automatically redirect to the Italian version. We use this on the Yarn site - You can look at how Yarn does it for inspirationI'd suggest
/<lang>/
(eg./<lang>/docs/<file>
), this is consistent with other Facebook projects that use localization:https://yarnpkg.com/en/docs/getting-started
https://flow.org/en/docs/getting-started/
We have perf issues with the Yarn site, but a lot of it is because we're using Jekyll. Most of the build time is actually the Jekyll build time rather than CrowdIn. We had a prototype using Hugo that was much faster. I don't think CrowdIn takes a significant amount of time there.
Would the React site actually need a custom API integration? It could be useful, but CrowdIn has a CLI tool (https://support.crowdin.com/cli-tool/) which we might be able to use with less effort. For Yarn we just run
crowdin-cli download -b master
to download all the localized files as part of the build (in that case, there's a bunch of Markdown files as well as some yml files for language strings). Then you just build the site like normal and everything just works, as long as the files are in the correct locations.bvaughn commentedon Oct 18, 2017
Don't have time to fully digest this response now- but wanted to mention that we should ensure whatever change we make does not break pre-existing links (like how links broke for Jest).
KyleAMathews commentedon Oct 18, 2017
It doesn't need it but it seems simpler perhaps to just query the data through graphql instead of writing it out first then pulling it in.
But yeah, definitely more straightforward to just use the cli.
Would you checkin the translated content?
Daniel15 commentedon Oct 18, 2017
Jest is limited in what it can do, because it's using GitHub Pages. With Netlify, you can generate some redirects as part of the build. Just need to redirect "raw" URLs (
/docs/foo
) to the localized URL (/en/docs/foo
), either with/en/
hard-coded or using Netlify's language redirects that I mentioned earlier (so it'd redirect/docs/foo
to/<user's preferred language>/docs/foo
).Check it out with Yarn: https://yarnpkg.com/docs/getting-started redirects to the right place. :)
We don't for Yarn. It's pulled in as part of the build process for the site. Since CrowdIn tracks the history for the translations, we didn't really need to also have Git track it.
Some sites do commit the translated files though. Up to you - Either way is fine.
bvaughn commentedon Oct 18, 2017
No
bvaughn commentedon Oct 18, 2017
Cool! 👍
Daniel15 commentedon Oct 18, 2017
Here's how the Yarn site builds all the redirects from non-localized URLs to localized URLs: https://github.com/yarnpkg/website/blob/master/_redirects#L48-L70 (this would also be how you handle your redirects from 'old' URLs to new localized URLs). Unfortunately the Yarn one is super difficult to understand because it's using the Jekyll templating syntax. Somehow @thejameskyle got it working though. You could likely make a nicer JS script to do the same thing for the React site.
The resulting redirects file looks something like this:
Here's the entire language redirects section: https://gist.github.com/Daniel15/d84b39e8a260ee2a7d627751d015181b
Docs: https://www.netlify.com/docs/redirects/#geoip-and-language-based-redirects
Might be able to use a regex or placeholders or something rather than having to generate all the redirects like that.
KyleAMathews commentedon Oct 18, 2017
@bvaughn wrote a nice redirect API for Gatsby + added it to gatsby-plugin-netlify so this setting up redirects would be pretty easy :-)
51 remaining items