Avoid an array allocation per element in list passed to seplist #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The array allocation was because the keyword splat expression is not recognized as safe by the compiler. Also avoid unnecessary >= method call per element. This uses a private constant to avoid unnecessary work at runtime. I assume the only reason this code is needed is because v may end with a ruby2_keywords hash that we do not want to treat as keywords. This issue was found by the performance warning in Ruby feature 21274.
tompng
reviewed
Apr 22, 2025
lib/pp.rb
Outdated
| } | ||
| end | ||
| EMPTY_HASH = if RUBY_VERSION >= "3.0" |
There was a problem hiding this comment.
How about EMPTY_KWHASH ?
EMPTY_HASH is not an empty hash in ruby < 3.0. This hash can't be used for a purpose other than empty keyword splat.
There was a problem hiding this comment.
Sure, renaming the constant is fine. I'll push a commit for that.
tompng
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array allocation was because the keyword splat expression is not recognized as safe by the compiler. Also avoid unnecessary
>=method call per element. This uses a private constant to avoid unnecessary work at runtime.I assume the only reason this code is needed is because
vmay end with aruby2_keywordshash that we do not want to treat as keywords.This issue was found by the performance warning in Ruby feature 21274.