Add SPLAT flag on ArrayNode indicating if it contains splat element(s)

This commit puts a SPLAT flag on any ArrayNodes which contain
SplatNode elements

Author: jemmaissroff

config.yml

@@ -331,9 +331,14 @@ tokens:
 flags:
   - name: ArgumentsNodeFlags
     values:
-      - name: KEYWORD_SPLAT
+      - name: CONTAINS_KEYWORD_SPLAT
         comment: "if arguments contain keyword splat"
     comment: Flags for arguments nodes.
+  - name: ArrayNodeFlags
+    values:
+      - name: CONTAINS_SPLAT
+        comment: "if array contains splat nodes"
+    comment: Flags for array nodes.
   - name: CallNodeFlags
     values:
       - name: SAFE_NAVIGATION
@@ -459,6 +464,9 @@ nodes:
         type: location?
       - name: closing_loc
         type: location?
+      - name: flags
+        type: flags
+        kind: ArrayNodeFlags
     comment: |
       Represents an array literal. This can be a regular array using brackets or
       a special array using % like %w or %i.

src/prism.c

@@ -1151,6 +1151,10 @@ pm_array_node_elements_append(pm_array_node_t *node, pm_node_t *element) {
     if (PM_NODE_TYPE_P(element, PM_ARRAY_NODE) || PM_NODE_TYPE_P(element, PM_HASH_NODE) || PM_NODE_TYPE_P(element, PM_RANGE_NODE) || (element->flags & PM_NODE_FLAG_STATIC_LITERAL) == 0) {
         node->base.flags &= (pm_node_flags_t) ~PM_NODE_FLAG_STATIC_LITERAL;
     }
+
+    if (PM_NODE_TYPE_P(element, PM_SPLAT_NODE)) {
+        node->base.flags |= PM_ARRAY_NODE_FLAGS_CONTAINS_SPLAT;
+    }
 }
 
 /**
@@ -11144,7 +11148,7 @@ parse_arguments(pm_parser_t *parser, pm_arguments_t *arguments, bool accepts_for
                 parsed_bare_hash = true;
                 parse_arguments_append(parser, arguments, argument);
                 if (contains_keyword_splat) {
-                    arguments->arguments->base.flags |= PM_ARGUMENTS_NODE_FLAGS_KEYWORD_SPLAT;
+                    arguments->arguments->base.flags |= PM_ARGUMENTS_NODE_FLAGS_CONTAINS_KEYWORD_SPLAT;
                 }
                 break;
             }
@@ -11258,7 +11262,7 @@ parse_arguments(pm_parser_t *parser, pm_arguments_t *arguments, bool accepts_for
 
                 parse_arguments_append(parser, arguments, argument);
                 if (contains_keyword_splat) {
-                    arguments->arguments->base.flags |= PM_ARGUMENTS_NODE_FLAGS_KEYWORD_SPLAT;
+                    arguments->arguments->base.flags |= PM_ARGUMENTS_NODE_FLAGS_CONTAINS_KEYWORD_SPLAT;
                 }
                 break;
             }