Mingw: Exclude failing tests due to the crt change#11991
Conversation
Mingw crt-git 12.0.0.r369.g0d4221712-1 now prohibits "command line contains characters that are not supported in the active code page". https://sourceforge.net/p/mingw-w64/mingw-w64/ci/0d42217123d3aec0341b79f6d959c76e09648a1e/ Provisionally exclude tests that fail by passing such characters.
|
This also broke one Bundler spec, which I'll be skipping similarly. Is this related to #11799 in any way, @larskanis? |
|
I don't understand what's different between Ruby 3.3.6 and Ruby 3.3.5 that makes the former use the broken version, though. |
|
Unfortunately this slipped through the release tests on RubyInstaller-3.3.6-1 since they are running on codepage 65001 (UTF-8) on Github so that this issue wasn't triggered. I'm working on a solution now, probably by using
Yes, somewhat - command line handling is inconsistent without #11799. |
|
I tried to repro this issue on ruby master to no avail, until I noticed that nobu already fixed it in 74fcf43 . I patched RubyInstaller and released 3.3.6-2 fixing this regression. |
|
Oh, indeed! Thanks so much both for the quick fix! |
Mingw crt-git 12.0.0.r369.g0d4221712-1 now prohibits "command line contains characters that are not supported in the active code page".
https://sourceforge.net/p/mingw-w64/mingw-w64/ci/0d42217123d3aec0341b79f6d959c76e09648a1e/
Provisionally exclude tests that fail by passing such characters.