Skip to content

Mingw: Exclude failing tests due to the crt change#11991

Merged
matzbot merged 1 commit intoruby:masterfrom
nobu:mingw-failures
Nov 4, 2024
Merged

Mingw: Exclude failing tests due to the crt change#11991
matzbot merged 1 commit intoruby:masterfrom
nobu:mingw-failures

Conversation

@nobu
Copy link
Member

@nobu nobu commented Nov 4, 2024

Mingw crt-git 12.0.0.r369.g0d4221712-1 now prohibits "command line contains characters that are not supported in the active code page".
https://sourceforge.net/p/mingw-w64/mingw-w64/ci/0d42217123d3aec0341b79f6d959c76e09648a1e/

Provisionally exclude tests that fail by passing such characters.

Mingw crt-git 12.0.0.r369.g0d4221712-1 now prohibits "command line
contains characters that are not supported in the active code page".
https://sourceforge.net/p/mingw-w64/mingw-w64/ci/0d42217123d3aec0341b79f6d959c76e09648a1e/

Provisionally exclude tests that fail by passing such characters.
@matzbot matzbot merged commit 09874e9 into ruby:master Nov 4, 2024
@nobu nobu deleted the mingw-failures branch November 4, 2024 13:53
@deivid-rodriguez
Copy link
Contributor

This also broke one Bundler spec, which I'll be skipping similarly.

Is this related to #11799 in any way, @larskanis?

@deivid-rodriguez
Copy link
Contributor

I don't understand what's different between Ruby 3.3.6 and Ruby 3.3.5 that makes the former use the broken version, though.

@larskanis
Copy link
Contributor

Unfortunately this slipped through the release tests on RubyInstaller-3.3.6-1 since they are running on codepage 65001 (UTF-8) on Github so that this issue wasn't triggered. I'm working on a solution now, probably by using wmain() as the entry point.

Is this related to #11799 in any way, @larskanis?

Yes, somewhat - command line handling is inconsistent without #11799.

@larskanis
Copy link
Contributor

I tried to repro this issue on ruby master to no avail, until I noticed that nobu already fixed it in 74fcf43 . I patched RubyInstaller and released 3.3.6-2 fixing this regression.

@deivid-rodriguez
Copy link
Contributor

Oh, indeed! Thanks so much both for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants