Skip to content

remove has_nested from builtin candidates #143571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

remove has_nested from builtin candidates #143571

merged 1 commit into from
Jul 8, 2025
+54 −66

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jul 7, 2025

it's no longer necessary

r? types

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 7, 2025
lcnr
lcnr commented Jul 7, 2025
View reviewed changes
compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs
candidates
.vec
.push(SizedCandidate { has_nested: !nested.skip_binder().is_empty() });
BuiltinImplConditions::Where(_nested) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could change assembly to not actually collect the nested types to avoid creating a vec only to drop it again. Doing this results in some additional code duplication so I didn't do it here 😁

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll do it in that other PR anyways lol

@lcnr
Copy link
Contributor Author

lcnr commented Jul 7, 2025

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Jul 7, 2025

⌛ Trying commit 3ddcf8b with merge 8e989de…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jul 7, 2025
@rust-bors
Auto merge of #143571 - lcnr:has_nested-bb, r=<try>
8e989de 
remove `has_nested` from builtin candidates

it's no longer necessary

r? types
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 7, 2025
@rust-bors
Copy link

rust-bors bot commented Jul 7, 2025

☀️ Try build successful (CI)
Build commit: 8e989de (8e989de2968f67a63f0ecec1beaaa6b51602bda6, parent: c720f49c46ec3e70bbc2bbb3e0dd1fe7fc0a47f2)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8e989de): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)		 0.8% [0.3%, 1.4%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) 1.4% [1.4%, 1.4%] 1

Max RSS (memory usage)

Results (primary 1.7%, secondary -4.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.7% [1.7%, 1.7%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.4% [-4.4%, -4.4%] 1
All ❌✅ (primary) 1.7% [1.7%, 1.7%] 1

Cycles

Results (secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 464.259s -> 464.483s (0.05%)
Artifact size: 372.10 MiB -> 372.14 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 7, 2025
@lcnr
Copy link
Contributor Author

lcnr commented Jul 7, 2025

looks like it's all just noise 😁

@lcnr lcnr mentioned this pull request Jul 7, 2025
Merged
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 7, 2025

📌 Commit 3ddcf8b has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned spastorino Jul 7, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 8, 2025
Merged
bors added a commit that referenced this pull request Jul 8, 2025
@bors
Auto merge of #143621 - matthiaskrgr:rollup-p1ce8l7, r=matthiaskrgr
2783fc4 
Rollup of 7 pull requests

Successful merges:

 - #142098 (Implement `int_format_into` feature)
 - #143567 (Point to correct argument in Func Call when Self type fails trait bound)
 - #143570 (consider nested cases for duplicate RPITIT)
 - #143571 (remove `has_nested` from builtin candidates)
 - #143586 (Fix wrong cache event query key)
 - #143589 (const-block-as-pattern: do not refer to no-longer-existing nightly feature)
 - #143608 (Fix in std::String docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b29f039 into rust-lang:master Jul 8, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 8, 2025
rust-timer added a commit that referenced this pull request Jul 8, 2025
@rust-timer
Unrolled build for #143571
2b2329d 
Rollup merge of #143571 - lcnr:has_nested-bb, r=compiler-errors

remove `has_nested` from builtin candidates

it's no longer necessary

r? types
@lcnr lcnr deleted the has_nested-bb branch July 8, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lcnr @rust-timer @compiler-errors @bors @spastorino @rustbot