Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serde-rs/serde
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.196
Choose a base ref
...
head repository: serde-rs/serde
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.197
Choose a head ref
  • 7 commits
  • 9 files changed
  • 2 contributors

Commits on Feb 8, 2024

  1. Ignore dead_code warnings in test

        warning: trait `AssertNotSerdeSerialize` is never used
          --> test_suite/tests/test_serde_path.rs:39:7
           |
        39 | trait AssertNotSerdeSerialize {}
           |       ^^^^^^^^^^^^^^^^^^^^^^^
           |
           = note: `#[warn(dead_code)]` on by default
    
        warning: trait `AssertNotSerdeDeserialize` is never used
          --> test_suite/tests/test_serde_path.rs:43:7
           |
        43 | trait AssertNotSerdeDeserialize<'a> {}
           |       ^^^^^^^^^^^^^^^^^^^^^^^^^
    
        warning: method `serialize` is never used
          --> test_suite/tests/test_serde_path.rs:31:12
           |
        30 |     pub trait Serialize {
           |               --------- method in this trait
        31 |         fn serialize<S: Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error>;
           |            ^^^^^^^^^
    
        warning: associated function `deserialize` is never used
          --> test_suite/tests/test_serde_path.rs:35:12
           |
        34 |     pub trait Deserialize<'a>: Sized {
           |               ----------- associated function in this trait
        35 |         fn deserialize<D: Deserializer<'a>>(deserializer: D) -> Result<Self, D::Error>;
           |            ^^^^^^^^^^^
    dtolnay committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    846f865 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Ignore incompatible_msrv clippy lint for conditionally compiled code

        warning: current MSRV (Minimum Supported Rust Version) is `1.31.0` but this item is stable since `1.35.0`
           --> serde/src/de/impls.rs:200:39
            |
        200 |                   Ok((v as Self::Value).copysign(sign))
            |                                         ^^^^^^^^^^^^^^
        ...
        374 | / impl_deserialize_num! {
        375 | |     f32, deserialize_f32
        376 | |     num_self!(f32:visit_f32);
        377 | |     num_as_copysign_self!(f64:visit_f64);
        378 | |     num_as_self!(i8:visit_i8 i16:visit_i16 i32:visit_i32 i64:visit_i64);
        379 | |     num_as_self!(u8:visit_u8 u16:visit_u16 u32:visit_u32 u64:visit_u64);
        380 | | }
            | |_- in this macro invocation
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
            = note: `-W clippy::incompatible-msrv` implied by `-W clippy::all`
            = help: to override `-W clippy::all` add `#[allow(clippy::incompatible_msrv)]`
            = note: this warning originates in the macro `num_as_copysign_self` which comes from the expansion of the macro `impl_deserialize_num` (in Nightly builds, run with -Z macro-backtrace for more info)
    
        warning: current MSRV (Minimum Supported Rust Version) is `1.31.0` but this item is stable since `1.35.0`
           --> serde/src/de/impls.rs:200:39
            |
        200 |                   Ok((v as Self::Value).copysign(sign))
            |                                         ^^^^^^^^^^^^^^
        ...
        382 | / impl_deserialize_num! {
        383 | |     f64, deserialize_f64
        384 | |     num_self!(f64:visit_f64);
        385 | |     num_as_copysign_self!(f32:visit_f32);
        386 | |     num_as_self!(i8:visit_i8 i16:visit_i16 i32:visit_i32 i64:visit_i64);
        387 | |     num_as_self!(u8:visit_u8 u16:visit_u16 u32:visit_u32 u64:visit_u64);
        388 | | }
            | |_- in this macro invocation
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
            = note: this warning originates in the macro `num_as_copysign_self` which comes from the expansion of the macro `impl_deserialize_num` (in Nightly builds, run with -Z macro-backtrace for more info)
    
        warning: current MSRV (Minimum Supported Rust Version) is `1.31.0` but this item is stable since `1.34.0`
            --> serde/src/de/impls.rs:2308:14
             |
        2308 |             .checked_add(duration)
             |              ^^^^^^^^^^^^^^^^^^^^^
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
    
        warning: current MSRV (Minimum Supported Rust Version) is `1.31.0` but this item is stable since `1.34.0`
           --> serde/src/ser/impls.rs:606:26
            |
        606 |                       self.get().serialize(serializer)
            |                            ^^^^^
        ...
        623 | / nonzero_integers! {
        624 | |     NonZeroI8,
        625 | |     NonZeroI16,
        626 | |     NonZeroI32,
        ...   |
        629 | |     NonZeroIsize,
        630 | | }
            | |_- in this macro invocation
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
            = note: this warning originates in the macro `nonzero_integers` (in Nightly builds, run with -Z macro-backtrace for more info)
    
        warning: current MSRV (Minimum Supported Rust Version) is `1.31.0` but this item is stable since `1.34.0`
            --> serde/src/ser/impls.rs:1053:26
             |
        1053 |                       self.load(Ordering::Relaxed).serialize(serializer)
             |                            ^^^^^^^^^^^^^^^^^^^^^^^
        ...
        1061 | / atomic_impl! {
        1062 | |     AtomicBool "8"
        1063 | |     AtomicI8 "8"
        1064 | |     AtomicI16 "16"
        ...    |
        1070 | |     AtomicUsize "ptr"
        1071 | | }
             | |_- in this macro invocation
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
             = note: this warning originates in the macro `atomic_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
    
        warning: current MSRV (Minimum Supported Rust Version) is `1.31.0` but this item is stable since `1.34.0`
            --> serde/src/ser/impls.rs:1053:26
             |
        1053 |                       self.load(Ordering::Relaxed).serialize(serializer)
             |                            ^^^^^^^^^^^^^^^^^^^^^^^
        ...
        1074 | / atomic_impl! {
        1075 | |     AtomicI64 "64"
        1076 | |     AtomicU64 "64"
        1077 | | }
             | |_- in this macro invocation
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
             = note: this warning originates in the macro `atomic_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
    dtolnay committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    9e68062 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Configuration menu
    Copy the full SHA
    c42ebb8 View commit details
    Browse the repository at this point in the history
  2. A few minor write_str optimizations and inlining

    Apparently `write!` generates more code than `write_str` when used with a simple string, so optimizing it.
    nyurik committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    b8fafef View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Merge pull request #2697 from nyurik/format-str

    A few minor `write_str` optimizations
    dtolnay authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1d54973 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Resolve prelude redundant import warnings

        warning: the item `Into` is imported redundantly
           --> serde/src/lib.rs:184:47
            |
        184 |     pub use self::core::convert::{self, From, Into};
            |                                               ^^^^
            |
           ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:115:13
            |
        115 |     pub use super::v1::*;
            |             --------- the item `Into` is already defined here
            |
            = note: `#[warn(unused_imports)]` on by default
    dtolnay committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f5d8ae4 View commit details
    Browse the repository at this point in the history
  2. Release 1.0.197

    dtolnay committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5fa711d View commit details
    Browse the repository at this point in the history
Loading