Skip to content

pass stmt.QueryString to QueryContext and ExecContext calls #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

Songmu
Copy link
Contributor

@Songmu Songmu commented Jan 7, 2021

This is to allow pre-rewriting by hooks.

What I want to do with this is to embed comments in the publish query, just like Teng and DBIx::Sunny in Perl.

It may be necessary to handle Prepare as well, but I'm not doing so at present.

There may be a little overhead because the assignment to stmt is always made for each invocation. What do you think?

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #61 (9abdebe) into main (cf38712) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   74.09%   74.03%   -0.06%     
==========================================
  Files          11       11              
  Lines         938      936       -2     
==========================================
- Hits          695      693       -2     
  Misses        174      174              
  Partials       69       69              
Impacted Files Coverage Δ
conn.go 69.18% <100.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf38712...9abdebe. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 78.538% when pulling 9abdebe on Songmu:overwrite-query into cf38712 on shogo82148:main.

Copy link
Owner

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shogo82148 shogo82148 merged commit b039787 into shogo82148:main Jan 8, 2021
@Songmu Songmu deleted the overwrite-query branch January 8, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants