-
Notifications
You must be signed in to change notification settings - Fork 875
Address cargo audit failure RUSTSEC-2025-0009
#7086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I guess we'd merge to release-v7.0.0 and then cherry-pick to unstable? |
Wondering if we should just merge an |
Hi @michaelsproul released |
I've updated libp2p-tls, and removed the relevant cargo audit ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You may have to fix your CI before adding the pull request to the queue again. If you want to requeue this pull request, you can post a |
Cross builds were failing since: - #7086 This seems to have been due to a regression upstream in `ring` which is noted in the v0.17.14 release notes. I'm hoping that updating remedies it. > Compatibility with GNU binutils 2.29 (used on Amazon Linux 2), and probably even earlier versions, was restored. It is expected that ring 0.17.14 will build on all the systems that 0.17.12 would build on. https://github.com/briansmith/ring/blob/main/RELEASES.md#version-01714-2025-03-11
Bump ring version to resolve cargo audit
https://github.com/sigp/lighthouse/actions/runs/13713278847/job/38353627642?pr=7085
https://rustsec.org/advisories/RUSTSEC-2025-0009