Skip to content

Update ring to 0.17.14 to fix build compat #7164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

Update ring to 0.17.14 to fix build compat #7164

merged 1 commit into from
Mar 19, 2025

Conversation

michaelsproul
Copy link
Member

Proposed Changes

Cross builds were failing since:

This seems to have been due to a regression upstream in ring which is noted in the v0.17.14 release notes. I'm hoping that updating remedies it.

Compatibility with GNU binutils 2.29 (used on Amazon Linux 2), and probably even earlier versions, was restored. It is expected that ring 0.17.14 will build on all the systems that 0.17.12 would build on.

https://github.com/briansmith/ring/blob/main/RELEASES.md#version-01714-2025-03-11

@michaelsproul michaelsproul added ready-for-review The code is ready for review crypto An issue/PR that touches cryptography code. dependencies Pull requests that update a dependency file v7.0.0-beta.clean Clean release post Holesky rescue labels Mar 18, 2025
michaelsproul added a commit that referenced this pull request Mar 18, 2025
@michaelsproul
Update ring to 0.17.14 to fix build compat (#7164)
fe77878 
Squashed commit of the following:

commit cf670eb
Author: Michael Sproul <[email protected]>
Date:   Tue Mar 18 17:56:40 2025 +1100

    Update ring to 0.17.14 to fix build compat
@michaelsproul michaelsproul mentioned this pull request Mar 18, 2025
Merged
@michaelsproul
Copy link
Member Author

This did fix the build. Just needs a green tick

realbigsean
realbigsean approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tick

@realbigsean realbigsean added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Mar 19, 2025
mergify bot added a commit that referenced this pull request Mar 19, 2025
@mergify
Merge of #7164
ce6010b
@mergify mergify bot mentioned this pull request Mar 19, 2025
Closed
6 tasks
@mergify mergify bot merged commit 76d8984 into sigp:release-v7.0.0 Mar 19, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realbigsean realbigsean realbigsean approved these changes

Assignees
No one assigned
Labels
crypto An issue/PR that touches cryptography code. dependencies Pull requests that update a dependency file ready-for-merge This PR is ready to merge. v7.0.0-beta.clean Clean release post Holesky rescue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsproul @realbigsean