Skip to content

Prevent connections from being closed too early due to weak refs expiring #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

fatho
Copy link
Contributor

@fatho fatho commented Jul 26, 2022

Fixes #489, see that issue or the included test for a description of the problem.

Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a minor version bump and a ChangeLog entry as well? Other than that, looks great!

Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lightning speed. Thank you!

@fatho
Copy link
Contributor Author

fatho commented Jul 26, 2022

Of course, done!

EDIT: I see you already saw :)

@snoyberg snoyberg merged commit fa340a9 into snoyberg:master Jul 26, 2022
ivo-stefchev pushed a commit to ivo-stefchev/http-client that referenced this pull request Jul 30, 2022
Prevent connections from being closed too early due to weak refs expiring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weak IORef results in too early release of connections
2 participants