-
Notifications
You must be signed in to change notification settings - Fork 839
Add T2 pr checker in azure-pipeline #17368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Will there be a large number of test scripts running in the T2 PR checker? In the impacted-area PR testing, we determine the instance count based on the runtime from the Baseline test. However, since there are no T2 results in the Baseline test, I’m concerned that we might end up using a significant number of instances. |
azure-pipelines.yml
Outdated
- template: .azure-pipelines/run-test-elastictest-template.yml | ||
parameters: | ||
TOPOLOGY: t2 | ||
TESTBED_NAME: vms-kvm-t2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr test in elastictest shouldn't pass testbed name, topo is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the elastic test backend automatically link the T2 topo to vms-kvm-t2 testbed in the inventory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, exactly
We don't know the number of existing test scripts that can pass on the T2 kvm testbed yet. Since, there is no history record of T2 result, can we use a fixed number of instances first? We can determine how we migrate to use the dynamic calculation based method later. |
Sure, we can use a fixed number of instances first, but we need to know how much time are needed to run all scripts. |
The only way to know how much time we need is measuring it with a number of instances out of intuition. For now, I will try 20 first. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
sanity of the t2 kvm testbed failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is test_vs_chassis_setup.py removed and what's the equivalent of it
executor.submit(config_reload, duthost, config_source='running_golden_config', | ||
safe_reload=True, | ||
check_intf_up_ports=True, wait_for_bgp=True) | ||
executor.submit(config_reload, duthost, config_source='minigraph', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change to using minigraph here?
Description of PR
Summary: Add a T2 PR checker in sonic-mgmt azure-pipeline
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation