This repository was archived by the owner on Jan 16, 2025. It is now read-only.
Target environment #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LSP spec allows implementations to ignore notifications if they want. This way glslls doesn't start emitting errors when new notifications are added in the future.
This fixes svenstaro#19. As an added benifit, neovim sends a "shutdown" message when closing, waiting about 1 second until the language server responds before terminating to give the server a chance to respond. Previously, this caused a slight hiccup whenever neovim was closed. By clearly stating that the "shutdown" message is not implemented by using the "id" field, neovim now closes immediately.
We supply a custom includer which looks for files in the current workspace, or adding them if they do not exist.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to specify which API to target (OpenGL/Vulkan) and the version of SPIR-V. These influence certain aspects of the diagnostics, and may unlock new builtin identifiers. For example, when Vulkan, we are allowed to use
local_size_x_id, but only when targeting recent SPIR-V versions. This adds two new CLI flags--target-envand--target-spvto change these values, respectively.This supercedes #24, as it keeps support open for OpenGL, without forcing Vulkan rules upon them.
As with my other recent PRs, this builds upon the previous #28, which should be merged first.