Switch to New Upbound DevEx #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
haarchri
reviewed
Mar 11, 2025
examples/network-xr.yaml
Outdated
| name: ref-azure-network | ||
| spec: | ||
| parameters: | ||
| id: ref-azure-network-from-xr | ||
| region: westus | ||
| deletionPolicy: Delete |
There was a problem hiding this comment.
You don't need this when using up composition render when you add the --xrd we will extract the defaults for the fields
There was a problem hiding this comment.
Should --xrd be the default? :)
There was a problem hiding this comment.
ah, scratch that, it is an explicit path
--xrd=PATH A YAML file specifying the
CompositeResourceDefinition (XRD) to validate
the XR against.
There was a problem hiding this comment.
Readme and sample XR updated
functions/xnetwork/main.k
Outdated
| networkv1beta2.VirtualNetwork { | ||
| metadata = _metadata("${params.id}-vnet") | ||
| spec = _add_common_spec_fields(networkv1beta2.NetworkAzureUpboundIoV1beta2VirtualNetworkSpec { | ||
| forProvider = networkv1beta2.NetworkAzureUpboundIoV1beta2VirtualNetworkSpecForProvider { |
There was a problem hiding this comment.
You don't need the typed for every sub property it's enough on the root of the resource - If you using : the lsp will not add these by default
There was a problem hiding this comment.
Removed redundant explicit embedded field typing 👍
Signed-off-by: Yury Tsarev <[email protected]>
* Add Composition Test workflows * Replace e2e test workflow with up cli based one Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Also simplify sample XR Signed-off-by: Yury Tsarev <[email protected]>
haarchri
previously approved these changes
Mar 12, 2025
Signed-off-by: Yury Tsarev <[email protected]>
haarchri
approved these changes
Mar 12, 2025
kaessert
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Switched this configuration to new Upbound DevEx including Project, CompositiionTest and E2ETest API.
Highlights:
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Composition tests E2E tests run with label were tested in ytsarev#1