Skip to content

Add SSL support #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Narigo opened this issue Mar 21, 2016 · 16 comments
Closed

Add SSL support #43

Narigo opened this issue Mar 21, 2016 · 16 comments
Milestone

Comments

@Narigo
Copy link
Contributor

Narigo commented Mar 21, 2016

It can be possible to use SSL encrypted connections with the newest driver version (0.2.19). I'll upgrade to that version shortly (that will fix another bug regarding NUMERIC columns) and then we are able to add SSL support.

@onesse
Copy link

onesse commented Jan 8, 2017

Hi,
You speak about the SSL support but I don't see how to enable it. I checked on forums and vertx website but there is no really clear explanations. Writing a small paragraph would be great :)
Regards

@Narigo
Copy link
Contributor Author

Narigo commented Jan 8, 2017

It's not supported yet. The driver could do it, but we need to add an API to use SSL in our client here as well.

@onesse
Copy link

onesse commented Jan 10, 2017

Ok, thanks for your response. Do you have any idea when this feature will be available ?

@Mart-Bogdan
Copy link
Contributor

Mart-Bogdan commented May 9, 2017

I've just encountered same problem.
It's seems quite straight forward to add support, will make PR soon.

It's impossible to run on Heroku w/o SSL :c

this line shouldbe altered https://github.com/vert-x3/vertx-mysql-postgresql-client/blob/issues/sql-options/src/main/java/io/vertx/ext/asyncsql/impl/BaseSQLClient.java#L105

Mart-Bogdan added a commit to Mart-Bogdan/vertx-mysql-postgresql-client that referenced this issue May 9, 2017
Now can be used with Heroku, as heroku supports only SSL
Mart-Bogdan added a commit to Mart-Bogdan/vertx-mysql-postgresql-client that referenced this issue May 9, 2017
Mart-Bogdan added a commit to Mart-Bogdan/vertx-mysql-postgresql-client that referenced this issue May 9, 2017
Mart-Bogdan added a commit to Mart-Bogdan/vertx-mysql-postgresql-client that referenced this issue May 12, 2017
Narigo pushed a commit that referenced this issue Sep 3, 2017
Now can be used with Heroku, as heroku supports only SSL
Narigo pushed a commit that referenced this issue Sep 3, 2017
Narigo pushed a commit that referenced this issue Sep 3, 2017
Mart-Bogdan added a commit to Mart-Bogdan/vertx-mysql-postgresql-client that referenced this issue Sep 13, 2017
@ghost
Copy link

ghost commented Dec 6, 2017

Is there any chance that #88 will be merged in any time soon?

Narigo added a commit that referenced this issue Dec 7, 2017
@vietj
Copy link
Contributor

vietj commented Dec 7, 2017

can we close this issue then ?

@vietj vietj added this to the 3.5.1 milestone Dec 7, 2017
@Narigo
Copy link
Contributor Author

Narigo commented Dec 7, 2017

Yes!

@Narigo Narigo closed this as completed Dec 7, 2017
@jbkoh
Copy link

jbkoh commented Feb 4, 2018

I know this is closed and the PR has been merged. When will the new version be released with this feature?

@vietj
Copy link
Contributor

vietj commented Feb 4, 2018

@jbkoh soon hopefully, it's being staged atm

@jbkoh
Copy link

jbkoh commented Feb 4, 2018

Thanks. I was wondering if I should start from java.sql directly or this.

@vietj
Copy link
Contributor

vietj commented Feb 4, 2018

what are you aiming for ?

@jbkoh
Copy link

jbkoh commented Feb 4, 2018

Just want to make a Vertx service communicate with (or query to) a remote PostgreSQL with SSL enabled. Are there other solutions for this?

@vietj
Copy link
Contributor

vietj commented Feb 4, 2018

@jbkoh
Copy link

jbkoh commented Feb 4, 2018

@vietj Thanks for the pointer. I see that you are the main author of both this and that. Could you briefly introduce what the difference is?

@vietj
Copy link
Contributor

vietj commented Feb 4, 2018

the client has been developed to be a client for postgres: it implements a bit more than the actual vertx-mysql-postgresql-client like batching, notifications, java 8 dates.

@jbkoh
Copy link

jbkoh commented Feb 4, 2018

Thanks for the prompt response. I will stick to the later. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants