-
Notifications
You must be signed in to change notification settings - Fork 1
Fineract.dev Demo Server Continous Deployment (CD) is broken since ~2021-09-21 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It has been failing since 22.09.2021 due to this error:
and some time over the weeks this error disappeared, and it now fails with some cryptic Google Cloud error which I do not yet understand. |
OK, so that Flyway related problem shown above is indeed not the cause. (Or perhaps there is another problem BEFORE that problem and I'll see that again later - I'll have "unroll" this step by step.) What's happening is that the internal liveness check fails - new versions never come alive on After a bit of digging (phew), I've found that the root cause of it is that new https://github.com/apache/fineract/blob/develop/entrypoint.sh which @IOhacker introduced in apache/fineract#1930 for https://issues.apache.org/jira/browse/FINERACT-1416. That, as-is currently, because the TL;DR That (new) |
https://issues.apache.org/jira/browse/FINERACT-1454 I'll pick this up when that is reviewed and merged. |
apache/fineract#2004 has been merged, but there is an unrelated other problem now:
on Fineract.dev I use Did Fineract recently change the JDBC driver that is shipped as part of the container image? I'll look into it. |
https://issues.apache.org/jira/browse/FINERACT-1456 I'll change the JDBC configuration used on https://www.fineract.dev. |
Phew, OK now there is ANOTHER (completely different problem) - see https://issues.apache.org/jira/browse/FINERACT-1457.
I'll attempt to upgrade the Google Cloud SQL MySQL DB version from 5.7 to 8.0. |
That worked - and now I'm back to that Subquery returns more than 1 row from I'll work around that by reseting the DB. |
That worked. https://demo.fineract.dev/fineract-provider/actuator/info now shows we're running the latest code again. I'll now merge apache/fineract#2001, just to convince myself the automation still fully works. |
That worked. https://demo.fineract.dev/fineract-provider/actuator/info now shows we're running code including apache/fineract@5efbd04. Problem solved & case closed. PS: This was surprinsgly painful! 😒 |
Thank you Michael for all of this digging. Any suggests for the future? |
I thought about that as well. I guess In a sort of "perfect world", any PR would be tested against Fineract.dev production upgrade. But this would require both time to set up and Cloud resources (you would need additional databases, because you would not want an in-Dev PR migration scripts to run on the "live" one, before merge) and some sort of queing infrastructure etc. etc. It's quite a bit of more work, more than I have time for. But even if I had the time and resources, I would have to argue that it would not be worth it, because: While it (this) was a onetime PITA, the CD to Fineract.dev has now (mostly) been "just working" almost completely "unattended" for 2 years already - in the overall bigger scheme of things, if we step back and squient at this, this is a actually huge success story! Unless it breaks with every other PR, I think a breakage once a year after major changes is "good enough". |
https://demo.fineract.dev/fineract-provider/actuator/info currently shows:
This doesn't look right, given https://github.com/apache/fineract/commits/develop.
I'd like to fix this so that apache/fineract#2001 can be used for #5.
@ptuomola @awasum @vidakovic FYI
The text was updated successfully, but these errors were encountered: