Added our proposal for changes to backdrop-filter #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstange
reviewed
Feb 26, 2019
chrishtr
reviewed
Mar 9, 2019
chrishtr
reviewed
Mar 9, 2019
chrishtr
reviewed
Mar 9, 2019
chrishtr
reviewed
Mar 9, 2019
chrishtr
reviewed
Mar 9, 2019
chrishtr
approved these changes
Mar 12, 2019
Contributor
chrishtr
left a comment
There was a problem hiding this comment.
LGTM % moving your name to the acknowldgements section per Tab's feedback.
chrishtr
reviewed
Mar 14, 2019
chrishtr
reviewed
Mar 14, 2019
chrishtr
reviewed
Mar 14, 2019
chrishtr
reviewed
Mar 14, 2019
Contributor
|
So, looks like changes were requested (even though the review was approved?) |
Contributor
Author
|
Let me know if there's anything else you need from me to get this merged. |
chrishtr
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to propose this change/expansion of the definition of backdrop-filter. It includes significant clarifications to what constitutes the "backdrop" of backdrop-filter, what the clipping behavior should be, and many other details.
Note that I've included the Bikeshed output (Overview.html) in this PR, just for ease of viewing by reviewers. The intention would be to delete that before merging the PR.