Skip to content

Make chosen an indexed lens to see which value was traversed #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

arybczak
Copy link
Collaborator

@arybczak arybczak commented Aug 6, 2020

No description provided.

Copy link
Member

@adamgundry adamgundry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, if slightly backwards incompatible. Should we continue to export chosen from Optics.Lens as well, since one might reasonably want it for non-indexed lenses, or at least retain a reference to chosen in the Optics.Lens docs somehow?

@arybczak
Copy link
Collaborator Author

arybczak commented Aug 23, 2020

We could export chosen from Optics.Lens, though at one point we might hit circular imports problem 🤔

On the other hand, breakage should be minimal (as usually you import umbrella modules such as Optics.Core or Optics) and there's changelog, index function on hackage and hoogle to get back on track.

@arybczak
Copy link
Collaborator Author

arybczak commented Aug 24, 2020

I added reference to chosen in Additional introduction forms of Optics.Lens.

@arybczak arybczak merged commit 2905a3b into master Aug 25, 2020
@arybczak arybczak deleted the indexed-chosen branch August 25, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants