Skip to content

Use indexed-traversable #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

Use indexed-traversable #370

merged 1 commit into from
Dec 17, 2020

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Dec 13, 2020

No description provided.

@arybczak
Copy link
Collaborator

arybczak commented Dec 13, 2020 •
edited
Loading

Thanks 👍

Is there a plan to reverse dependencies of inxeded-traversable-instances?

@phadej
Copy link
Contributor Author

phadej commented Dec 13, 2020

Is there a plan to reverse dependencies of inxeded-traversable-instances?

From package description, https://hackage.haskell.org/package/indexed-traversable-instances-0.1/candidate

The intention is to keep this package minimal; it provides instances that formely existed in lens or optics-extra. We recommend putting other instances directly into their defining packages. The indexed-traversable package is light, having only GHC boot libraries as its dependencies.

@arybczak
Copy link
Collaborator

Right. I suppose we can reverse dependencies of at least comonad after.

@phadej
Copy link
Contributor Author

phadej commented Dec 13, 2020

If you are worried about comonad, let me see if it's easy reverse now (without bumping oldest-supported GHC of comonad)

@phadej phadej mentioned this pull request Dec 13, 2020
Merged
@phadej
Copy link
Contributor Author

phadej commented Dec 13, 2020

Re comonad. See haskellari/indexed-traversable#4 (comment)

@phadej phadej force-pushed the indexed-traversable branch from f7f9028 to 8d3ec80 Compare December 15, 2020 17:46
@arybczak arybczak self-requested a review December 17, 2020 08:18
arybczak
arybczak approved these changes Dec 17, 2020
View reviewed changes
Copy link
Collaborator

@arybczak arybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉 Feel free to merge.

@phadej phadej merged commit b78cae8 into master Dec 17, 2020
@phadej phadej deleted the indexed-traversable branch December 17, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arybczak arybczak arybczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phadej @arybczak