Skip to content

Multiple assignees for merge requests

Problem to solve

It is quite common for multiple people to work on the same merge request together, for example a backend engineer and frontend engineer. In the same way that it is helpful to have multiple assignees for an issue, it would be very helpful for multiple assignees fro merge requests.

Additionally, when reviewing a large merge request, it is not uncommon for multiple people to be reviewing the merge request at the same time. Assigning oneself is helpful for indicating which people are reviewing the merge request.

Target audience

Further details

Original description

If we will be extending this feature to merge requests following the implementation of https://gitlab.com/gitlab-org/gitlab-ee/issues/1904 we should think about showing not allowed to merge slightly different

this was an answer to a question from @ClemMakesApps here https://gitlab.com/gitlab-org/gitlab-ee/issues/1904#note_25975510

coming from https://gitlab.com/gitlab-org/gitlab-ce/issues/4175 (way back 😄 )

We currently allow a MR to be assigned to any project member, regardless of role. This can be useful. For example, if the master role reviews the MR and requires changes of the developer, the MR can be reassigned to the developer while changes are in process. However, it is also possible that the MR gets assigned to a member with the intention of having them merge it. The assigner would have no immediate indication they had assigned the MR to someone that can't actually merge it. It would be nice to have some small indicator that you've assigned the MR to someone that can't merge to the target branch.

Bitmap_Copy

Proposal

Make it possible for multiple users to be assigned to a Merge Request in the same way that multiple people can be assigned to an *Issue

  • Change the icon (red is to heavy)
  • Change how this is displayed slightly with multiple people
  • Ordering the current assignees so that people that can merge appear first (to improve scan ability)

image

svg:

Permissions and Security

Documentation

TODO

What does success look like, and how can we measure that?

Increased merge request usage (and happier existing users of merge requests)

Links / references

Edited by 🤖 GitLab Bot 🤖