Using the new profile menu on mobile, I notice that clicking any of these buttons
shows basically the same result - the top of the user profile page, which only has a navigation menu. You have to scroll down a lot to actually see what you came for.
I agree itâs odd to arrive at basically the profile menu on mobile when clicking these links. the idea of displaying results in the menu panel, like notifications, is interesting! or at least jump down to an anchor in the results?
I like this idea! Although youâd need a âtabâ (since thatâs basically how these would function now) for notifications as well, to return to it.
Seems like 80+% of the time youâre only looking for recent bookmarks, messages, etc., so this might be useful.
You might also need a divider between the tabs and the settings icon though, since they now have different functions.
Basically profile page needs fixing. As @sam indicated it might be better if, when you view your own profile only, we compress the top part. Itâs especially large on mobile tooâŠ
I think this change looks good, well done @nbianca, provided âview older {x}âŠâ is updated to be conditional and link to the right place in each view:
view older bookmarksâŠ
view older messagesâŠ
view older notificationsâŠ
technically assignments are included here as well @sam â
This should be reviewed closely as it is a reasonably large changeâŠ
I think I would like to see this in a theme component first. API improvements that make this theme component doable (and clean up core as needed) are totally welcome along the way. But I think theme is a perfect place to test out this concept!
Then we can install on meta and âliveâ with it for a bit and see if it makes us happy, also our core API plus theme component infrastructure gets better along the way which is a huge plus.
Iâve made sure the design is easy for other plugins/themes to provide their own quick access panel. I will document this in detail (or PR an example to discourse-assign) if and when there is interest.
Not sure whatâs the best approach to this. I added the existing empty state help text from their respective âfull pageâ for now. The bookmarks one might be too long for a quick access panel.
Awesome work, this is very polished. I love that a second click takes you to the page.
This is installed here on meta, just pick Sam's Simple Theme to try it out in the hamburger.
Some feedback:
This should work with discourse-assign, try installing it and assigning something to yourself.
I feel the yellow is too much here style wise, @Johani / @awesomerobot any ideas for less noisy styling.
Not sure what to do about this, but on mobile the click targets are just too tiny. Maybe the component should make stuff a bit bigger so you have a shot at changing stuff?
Prefs is âdifferentâ maybe it should be the same and add a list for SummaryActivity or perhaps a list with AccountProfileEmails and so on.
a. Actually ⊠thinking about it, maybe you would drop the cog altogether and use the âperson samâ icon to drop down a panel with Summary, Activity and so on. That gives you a big more click target area for the tabs.
Thanks for the feedback! Just pushed an update to address the first two items. Will follow-up the other two later this week (#4 will require a minor PR to core first).
This is fantastic! How fantastic you ask? So fantastic I enabled it on all themes on meta.
Everyone feel free to have a play with this and give feedback. This is almost, imo, ready for core inclusion but we have some niggly things to sort out here.
The gear is not a tab. It feels really out of place. If you remove it then you can make all the tabs a bit wider which will help having bigger click targets on mobile! I think you should try removing it.
Showing âLog outâ on every tab to me feels like way too much, why are we inviting people to log out just cause they are looking at notifications? Seems like mixed concerns.
My recommendation here is
Remove logout from all subtabs
Add a new tab for when you click on person sam on the left. It can have âsummaryâ, âactivityâ, âmessagesâ âprefrencesâ âlog outâ links.
Once these niggles are sorted I am thinking this is a prime candidate for inclusion in core.
I noticed one very small issue - this component seems to affect the color of icons elsewhere in the app (e.g. the âwatchingâ status). Normally the icon is blue here:
I like that idea - how about also adding quick-access to theme and font size to âthe sam tabâ? The hamburger menu here on Meta is getting quite cluttered with theme options, so moving it somewhere else would be nice.
A big +1 on this - I think this will make the assign plugin much more useful and actionable.
I like these changes too and look forward to trying them out. Not sure itâs a good idea to bury âlog outâ behind another click, but agree it seems out of place where it is now so willing to try it. I was going to suggest putting it where the preferences icon is now but agree that they seem out of place and we donât want to encourage people to log out whenever they go to that menu.
It would be nice also if it were possible to provide one or two custom links within person sam. We use wordpress SSO so have to send folks over to wordpress to edit their profile and email address settings.