Page MenuHomePhabricator
Differential D173904

Bug 1808410 - Part 2: Add animation-timeline: view() in style system.
ClosedPublic
Actions

Authored by boris on Mar 28 2023, 11:18 PM.
Tags
Referenced Files
Unknown Object (File)
Sat, Nov 1, 8:59 PM
Unknown Object (File)
Mon, Oct 13, 4:07 AM
Unknown Object (File)
Oct 11 2025, 11:30 AM
Unknown Object (File)
Jun 18 2025, 8:25 PM
Unknown Object (File)
Jun 16 2025, 4:48 AM
Unknown Object (File)
May 26 2025, 5:20 PM
Unknown Object (File)
May 24 2025, 2:14 AM
Unknown Object (File)
May 22 2025, 7:51 AM
View All 20 Files
Subscribers
emilio

Details

Reviewers
emilio
Commits
rMOZILLACENTRAL259614987813: Bug 1808410 - Part 2: Add animation-timeline: view() in style system. r=emilio
Bugzilla Bug ID
1808410
Summary

Support view() notation for animation-timeline:

`<view()> = view( [ <axis> || <'view-timeline-inset'> ]? )`

We move AnimationTimeline and its related types into the generics folder,
and define two new structs for scroll() and view().

Note:

  1. The syntax of scroll() doesn't match the current version of the spec. I will update it in Bug 1814444.
  2. We will handle the creation/usage of the Anonymous View Progress Timelines in the next patch.

Diff Detail

Event Timeline

boris created this revision.Mar 28 2023, 11:18 PM
Herald added a project: secure-revision. · View Herald TranscriptMar 28 2023, 11:18 PM
Harbormaster completed remote builds in B521840: Diff 698539.Mar 28 2023, 11:18 PM
boris added a child revision: D173905: Bug 1808410 - Part 3: Create timeline for view()..Mar 28 2023, 11:18 PM
phab-bot published this revision for review.Mar 28 2023, 11:18 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: emilio. · View Herald TranscriptMar 28 2023, 11:18 PM
boris updated this revision to Diff 705730.Apr 17 2023, 9:39 PM
Harbormaster completed remote builds in B528072: Diff 705730.Apr 17 2023, 9:39 PM
boris updated this revision to Diff 706201.Apr 18 2023, 7:16 PM

Fix clang-format warnings

boris edited the summary of this revision. (Show Details)Apr 18 2023, 7:16 PM
Harbormaster completed remote builds in B528442: Diff 706201.Apr 18 2023, 7:16 PM
boris added reviewers: layout-reviewers, Restricted Project.Apr 18 2023, 7:17 PM
emilio requested changes to this revision.Apr 20 2023, 12:09 PM
emilio added inline comments.
servo/components/style/values/generics/ui.rs
223 ↗(On Diff #706201)

This is not generic, maybe should remain in specified?

249 ↗(On Diff #706201)

We generally don't put the bounds here and put them on the specific implementations, is there any reason that doesn't work?

279 ↗(On Diff #706201)

Same comment here.

299 ↗(On Diff #706201)

That way it's not needed here.

338 ↗(On Diff #706201)

Random change?

servo/components/style/values/specified/ui.rs
405 ↗(On Diff #706201)

Maybe just parse_arguments?

488 ↗(On Diff #706201)

Do you really need the turbofish?

This revision now requires changes to proceed.Apr 20 2023, 12:09 PM
boris marked 7 inline comments as done.Apr 20 2023, 11:06 PM
boris added inline comments.
servo/components/style/values/generics/ui.rs
249 ↗(On Diff #706201)

Because I use is_default() for ToCss, and is_default() requires these bounds. Perhaps a better way is to implement ToCss manually, and add #[css(field_bound)] to AnimationTimeline because these bounds are only for ToCss.

servo/components/style/values/specified/ui.rs
488 ↗(On Diff #706201)

After removing the bounds from the generic type, we can remove ::<LengthPercentage>.

boris updated this revision to Diff 707568.Apr 20 2023, 11:07 PM
boris marked 2 inline comments as done.

Addressed comments

Harbormaster completed remote builds in B529671: Diff 707568.Apr 20 2023, 11:07 PM
boris updated this revision to Diff 707597.Apr 21 2023, 1:10 AM

fix devtool css db

Harbormaster completed remote builds in B529694: Diff 707597.Apr 21 2023, 1:10 AM
emilio requested changes to this revision.Apr 22 2023, 10:14 PM
emilio added inline comments.
servo/components/style/values/generics/ui.rs
249 ↗(On Diff #706201)

I don't know why you'd need the ToCss bound in any case (is_default doesn't require it does it?)

What about instead of an over-generic is_default we do something like adding GenericViewTimelineInset::is_auto, and use it there instead? Seems like that should work?

This revision now requires changes to proceed.Apr 22 2023, 10:14 PM
boris added inline comments.Apr 24 2023, 8:03 PM
servo/components/style/values/generics/ui.rs
249 ↗(On Diff #706201)

Sorry. Right. It works. :)

boris updated this revision to Diff 708657.Apr 24 2023, 8:23 PM

Addressed comments

Harbormaster completed remote builds in B530579: Diff 708657.Apr 24 2023, 8:23 PM
emilio accepted this revision as: emilio.May 1 2023, 1:00 PM
emilio added a project: testing-approved.
emilio removed reviewers: layout-reviewers, Restricted Project.
This revision is now accepted and ready to land.May 1 2023, 1:00 PM
boris updated this revision to Diff 710682.May 1 2023, 7:29 PM

Rebased

Harbormaster completed remote builds in B532300: Diff 710682.May 1 2023, 7:29 PM
boris updated this revision to Diff 711343.May 2 2023, 10:45 PM

Fix devtool css db

Harbormaster completed remote builds in B532839: Diff 711343.May 2 2023, 10:45 PM
Closed by commit rMOZILLACENTRAL259614987813: Bug 1808410 - Part 2: Add animation-timeline: view() in style system. r=emilio (authored by boris). · Explain WhyMay 2 2023, 10:56 PM
This revision was automatically updated to reflect the committed changes.
boris added a commit: rMOZILLACENTRAL259614987813: Bug 1808410 - Part 2: Add animation-timeline: view() in style system. r=emilio.

Revision Contents
Changeset List

PathSize
devtools/
shared/
css/
generated/
9 lines
layout/
style/
4 lines
test/
8 lines
servo/
components/
style/
values/
computed/
5 lines
generics/
81 lines
specified/
147 lines
testing/
web-platform/
meta/
scroll-animations/
css/
6 lines
36 lines
62 lines

Diff 711351

View Options

devtools/shared/css/generated/properties-db.js

Loading...
View Options

layout/style/nsAnimationManager.cpp

Loading...
View Options

layout/style/test/property_database.js

Loading...
View Options

servo/components/style/values/computed/animation.rs

Loading...
View Options

servo/components/style/values/generics/animation.rs

Loading...
View Options

servo/components/style/values/specified/animation.rs

Loading...
View Options

testing/web-platform/meta/scroll-animations/css/animation-shorthand.html.ini

Loading...
View Options

testing/web-platform/meta/scroll-animations/css/animation-timeline-computed.html.ini

Loading...
View Options

testing/web-platform/meta/scroll-animations/css/animation-timeline-parsing.html.ini

Loading...
Privacy · Cookies · Legal