Page MenuHomePhabricator
Differential D261726

WIP: Bug 1984029 - Improve tests for gecko-trace component
Changes PlannedPublicDraft
Actions

Authored by mvanstraten on Aug 20 2025, 11:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 13 2025, 6:08 AM
Unknown Object (File)
Oct 12 2025, 4:48 PM
Unknown Object (File)
Oct 12 2025, 4:31 PM
Unknown Object (File)
Oct 11 2025, 7:12 PM
Unknown Object (File)
Oct 4 2025, 9:50 AM
Unknown Object (File)
Oct 4 2025, 6:44 AM
Unknown Object (File)
Oct 3 2025, 7:32 AM
Unknown Object (File)
Oct 2 2025, 11:19 PM
View All 17 Files
Subscribers
reviewbot

Details

Reviewers
None
Bugzilla Bug ID
1984029

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Event Timeline

mvanstraten planned changes to this revision.Aug 20 2025, 11:54 AM
mvanstraten created this revision.
Herald added a project: secure-revision. · View Herald TranscriptAug 20 2025, 11:54 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Aug 20 2025, 11:54 AM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Harbormaster failed remote builds in B836975: Diff 1108606!Aug 20 2025, 11:55 AM
mvanstraten added a parent revision: D255175: Bug 1930954 - Part 7: Add telementry trace aggregation r=nika.Aug 20 2025, 11:57 AM
mvanstraten added a child revision: D261709: Bug 1984041 - Extend DOM storage instrumentation with gecko-trace component r=janv.
mvanstraten planned changes to this revision.Sep 1 2025, 4:12 PM
mvanstraten updated this revision to Diff 1115019.
mvanstraten retitled this revision from WIP: Bug 1930954 - Part 8: Test new features added in this stack r=jari to WIP: Bug 1930954 - Part 9: Test new features added in this stack r=jari.
reviewbot added a subscriber: reviewbot.Sep 1 2025, 5:01 PM

The analysis task source-test-clang-external failed, but we could not detect any defect.
Please check this task manually.

The analysis task source-test-clang-tidy failed, but we could not detect any defect.
Please check this task manually.

If you see a problem in this automated review, please report it here.

Harbormaster failed remote builds in B842025: Diff 1115019!Sep 1 2025, 5:01 PM
mvanstraten edited parent revisions, added: D263303: Bug 1984029 - Add support for array attribute types r=jari; removed: D255175: Bug 1930954 - Part 7: Add telementry trace aggregation r=nika.Sep 2 2025, 11:52 AM
mvanstraten planned changes to this revision.Sep 2 2025, 3:15 PM
mvanstraten updated this revision to Diff 1115480.
reviewbot added a comment.Sep 2 2025, 4:04 PM

Code analysis found 1 defect in diff 1115480:

  • 1 defect found by cargo-audit (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1115480.

Harbormaster failed remote builds in B842421: Diff 1115480!Sep 2 2025, 4:04 PM
mvanstraten planned changes to this revision.Sep 3 2025, 7:00 AM
mvanstraten updated this revision to Diff 1115931.
reviewbot added a comment.Sep 3 2025, 7:54 AM
NOTE: Tasks were added or removed in diff 1115931.

The following parameter sets have differences:

If you see a problem in this automated review, please report it here.

Harbormaster completed remote builds in B842759: Diff 1115931.Sep 3 2025, 7:55 AM
mvanstraten planned changes to this revision.Sep 3 2025, 6:15 PM
mvanstraten updated this revision to Diff 1116314.
reviewbot added a comment.Sep 3 2025, 7:07 PM

Code analysis found 1 defect in diff 1116314:

  • 1 defect found by gecko-trace (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing
NOTE: Tasks were added or removed in diff 1116314.

The following parameter sets have differences:

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1116314.

Harbormaster failed remote builds in B843075: Diff 1116314!Sep 3 2025, 7:07 PM
mvanstraten planned changes to this revision.Sep 4 2025, 1:11 PM
mvanstraten updated this revision to Diff 1116881.
mvanstraten planned changes to this revision.Sep 4 2025, 1:42 PM
mvanstraten updated this revision to Diff 1116926.
Harbormaster failed remote builds in B843537: Diff 1116881!Sep 4 2025, 2:16 PM
reviewbot added a comment.Sep 4 2025, 2:34 PM
NOTE: Tasks were added or removed in diff 1116926.

The following parameter sets have differences:

If you see a problem in this automated review, please report it here.

Harbormaster completed remote builds in B843566: Diff 1116926.Sep 4 2025, 2:35 PM
mvanstraten planned changes to this revision.Sep 4 2025, 2:48 PM
mvanstraten updated this revision to Diff 1117022.
reviewbot added a comment.Sep 4 2025, 3:47 PM
NOTE: Tasks were added or removed in diff 1117022.

The following parameter sets have differences:

If you see a problem in this automated review, please report it here.

Harbormaster completed remote builds in B843647: Diff 1117022.Sep 4 2025, 3:47 PM
mvanstraten planned changes to this revision.Sep 5 2025, 8:08 AM
mvanstraten updated this revision to Diff 1117608.
reviewbot added a comment.Sep 5 2025, 8:51 AM
NOTE: Tasks were added or removed in diff 1117608.

The following parameter sets have differences:

If you see a problem in this automated review, please report it here.

Harbormaster completed remote builds in B844104: Diff 1117608.Sep 5 2025, 8:51 AM
mvanstraten removed a child revision: D261709: Bug 1984041 - Extend DOM storage instrumentation with gecko-trace component r=janv.Sep 22 2025, 6:41 AM
mvanstraten planned changes to this revision.Sep 26 2025, 8:20 AM
mvanstraten updated this revision to Diff 1128326.
mvanstraten retitled this revision from WIP: Bug 1930954 - Part 9: Test new features added in this stack r=jari to WIP: Bug 1984092 - Improve tests for gecko-trace component.
mvanstraten changed the Bugzilla Bug ID from 1930954 to 1984092.
reviewbot added a comment.Sep 26 2025, 9:17 AM

The analysis task source-test-taskgraph-diff failed, but we could not detect any defect.
Please check this task manually.

If you see a problem in this automated review, please report it here.

Harbormaster failed remote builds in B852623: Diff 1128326!Sep 26 2025, 9:17 AM
mvanstraten planned changes to this revision.Sep 26 2025, 1:20 PM
mvanstraten updated this revision to Diff 1128503.
mvanstraten retitled this revision from WIP: Bug 1984092 - Improve tests for gecko-trace component to WIP: Bug 1984029 - Improve tests for gecko-trace component.
mvanstraten changed the Bugzilla Bug ID from 1984092 to 1984029.
reviewbot added a comment.Sep 26 2025, 2:10 PM
NOTE: Tasks were added or removed in diff 1128503.

The following parameter sets have differences:

If you see a problem in this automated review, please report it here.

Harbormaster completed remote builds in B852744: Diff 1128503.Sep 26 2025, 2:10 PM
mvanstraten added a child revision: D266308: Bug 1984029 - Rename gecko-trace metric and ping r=jari.Sep 29 2025, 7:51 AM
mvanstraten removed a child revision: D266308: Bug 1984029 - Rename gecko-trace metric and ping r=jari.
mvanstraten edited parent revisions, added: D266308: Bug 1984029 - Rename gecko-trace metric and ping r=jari; removed: D263303: Bug 1984029 - Add support for array attribute types r=jari.

Revision Contents
Changeset List

Diff 1128503

View Options

toolkit/components/gecko-trace/src/proto.rs

Loading...
View Options

toolkit/components/gecko-trace/tests/gtest/Common.h

Loading...
View Options

toolkit/components/gecko-trace/tests/gtest/TestDisabledComponent.cpp

Loading...
View Options

toolkit/components/gecko-trace/tests/gtest/TestEnabledComponent.cpp

Loading...
View Options

toolkit/components/gecko-trace/tests/gtest/TestEventDefinitions.cpp

Loading...
View Options

toolkit/components/gecko-trace/tests/gtest/TestGeckoTraceAPI.cpp

Loading...
View Options

toolkit/components/gecko-trace/tests/gtest/TestGeneratedEvents.cpp

Loading...
View Options

toolkit/components/gecko-trace/tests/gtest/gecko-trace.yaml

Loading...
View Options

toolkit/components/gecko-trace/tests/gtest/moz.build

Loading...
Privacy · Cookies · Legal