Page MenuHomePhabricator

Bug 1998052: Update wgpu to upstream 690d4ee0 (2025-11-06) r=#webgpu-reviewers!
Needs ReviewPublic

Authored by aleiserson on Wed, Nov 5, 5:56 PM.

Details

Reviewers
None
Group Reviewers
webgpu-reviewers
Restricted Project
Bugzilla Bug ID
1998052

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Event Timeline

phab-bot published this revision for review.Wed, Nov 5, 5:57 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

There are test failures like the following, which appear to be a regression:

[task 2025-11-05T18:10:43.428+00:00] 18:10:43     INFO - TEST-UNEXPECTED-FAIL | /_mozilla/webgpu/cts/webgpu/api/operation/rendering/3d_texture_slices/cts.https.html?q=webgpu:api,operation,rendering,3d_texture_slices:multiple_color_attachments,same_slice_with_diff_mip_levels:* | :depthSlice=0 - assert_unreached: 
[task 2025-11-05T18:10:43.428+00:00] 18:10:43     INFO -   - EXPECTATION FAILED: Array had unexpected contents at indices 1 through 771.
[task 2025-11-05T18:10:43.428+00:00] 18:10:43     INFO -      Starting at index 0:
[task 2025-11-05T18:10:43.428+00:00] 18:10:43     INFO -        actual == 0x: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ...
[task 2025-11-05T18:10:43.428+00:00] 18:10:43     INFO -        failed ->        xx    xx                                                                                              ...
[task 2025-11-05T18:10:43.429+00:00] 18:10:43     INFO -      expected ==     00 ff 00 ff 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ...
[task 2025-11-05T18:10:43.429+00:00] 18:10:43     INFO -       at (elided: below max severity)
[task 2025-11-05T18:10:43.429+00:00] 18:10:43     INFO -   - EXCEPTION: Error: Unexpected validation error occurred: In a pass parameter, caused by: Attachments have differing sizes: the color attachment at index 0's texture view has extent (1, 1, 1) but is followed by the color attachment at index 1's texture view which has (0, 0, 1)
[task 2025-11-05T18:10:43.429+00:00] 18:10:43     INFO -     TestFailedButDeviceReusable@https://web-platform.test:8443/_mozilla/webgpu/webgpu/util/device_pool.js:23:1
[task 2025-11-05T18:10:43.429+00:00] 18:10:43     INFO -     attemptEndTestScope@https://web-platform.test:8443/_mozilla/webgpu/webgpu/util/device_pool.js:465:13
[task 2025-11-05T18:10:43.429+00:00] 18:10:43     INFO -     
[task 2025-11-05T18:10:43.429+00:00] 18:10:43     INFO -  Reached unreachable code
[task 2025-11-05T18:10:43.429+00:00] 18:10:43     INFO - wpt_fn@https://web-platform.test:8443/_mozilla/webgpu/common/runtime/wpt.js:81:25
[task 2025-11-05T18:10:43.430+00:00] 18:10:43     INFO -

LGTM so far; I see you're filed some PRs to handle the regressions. I guess we'll update this patch to consume those fixes before updating metadata here?

aleiserson updated this revision to Diff 1152137.
aleiserson retitled this revision from Bug 1998052: Update wgpu to upstream ccc650fd (2025-11-04) r=#webgpu-reviewers! to Bug 1998052: Update wgpu to upstream 690d4ee0 (2025-11-06) r=#webgpu-reviewers!.

Code analysis found 2 defects in diff 1152137:

  • 2 defects found by cargo-audit (Mozlint)
WARNING: Found 2 defects (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

The analysis task source-test-doc-upload failed, but we could not detect any defect.
Please check this task manually.


If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1152137.

Code analysis found 2 defects in diff 1152171:

  • 2 defects found by cargo-audit (Mozlint)
WARNING: Found 2 defects (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1152171.

Updated the patch with the metadata changes for newly passing tests. I didn't include the rest of the metadata changes (for timeouts) because I feel like the job had more than usual... I am doing another try run now to confirm the metadata updates and can see how that goes.

Code analysis found 2 defects in diff 1152247:

  • 2 defects found by cargo-audit (Mozlint)
WARNING: Found 2 defects (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1152247.