Page MenuHomePhabricator
Differential D268165

Bug 1993368 - Part 3: Change the Homepage background color to use Material3 surface color token
AcceptedPublic
Actions

Authored by gl on Oct 9 2025, 3:30 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Nov 2, 1:24 PM
Unknown Object (File)
Sat, Oct 25, 10:43 AM
Unknown Object (File)
Fri, Oct 24, 6:51 PM
Unknown Object (File)
Fri, Oct 24, 12:29 PM
Unknown Object (File)
Mon, Oct 20, 1:50 PM
Unknown Object (File)
Sun, Oct 19, 7:29 AM
Unknown Object (File)
Sat, Oct 18, 2:04 PM
Unknown Object (File)
Wed, Oct 15, 11:33 AM
Subscribers
007
emilio
reviewbot

Details

Reviewers
007
Group Reviewers
android-reviewers
Bugzilla Bug ID
1993368

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Event Timeline

gl created this revision.Oct 9 2025, 3:30 PM
Herald added a project: secure-revision. · View Herald TranscriptOct 9 2025, 3:30 PM
phab-bot published this revision for review.Oct 9 2025, 3:31 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a reviewer: android-reviewers. · View Herald TranscriptOct 9 2025, 3:31 PM
Herald added a subscriber: emilio. · View Herald Transcript
007 added a subscriber: 007.Oct 9 2025, 3:34 PM
007 added inline comments.
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
1204–1206

do we even have to set a background color on the Window if the Homepage is 100% compose, or is there some color leaking through on the status bar/nav bar?

reviewbot added a subscriber: reviewbot.Oct 9 2025, 4:22 PM

Code analysis found 2 defects in diff 1136696:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1136696.

Harbormaster failed remote builds in B859098: Diff 1136696!Oct 9 2025, 4:22 PM
gl updated this revision to Diff 1137829.Mon, Oct 13, 4:05 PM
gl marked an inline comment as done.
gl added a child revision: D268420: Bug 1993655 - Part 1: Migrate the Bottom Sheet Handle to the M3 Acorn specs.
gl planned changes to this revision.Mon, Oct 13, 4:07 PM
reviewbot added a comment.Mon, Oct 13, 5:00 PM

Code analysis found 2 defects in diff 1137829:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1137829.

Harbormaster failed remote builds in B860051: Diff 1137829!Mon, Oct 13, 5:00 PM
gl requested review of this revision.Mon, Oct 13, 5:13 PM
gl updated this revision to Diff 1137875.
reviewbot added a comment.Mon, Oct 13, 5:57 PM

Code analysis found 2 defects in diff 1137875:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1137875.

Harbormaster failed remote builds in B860090: Diff 1137875!Mon, Oct 13, 5:57 PM
007 accepted this revision.Wed, Oct 15, 9:40 PM
007 added a project: testing-exception-ui (Only changes ui styling, images, or localized strings).
This revision is now accepted and ready to land.Wed, Oct 15, 9:40 PM
gl updated this revision to Diff 1139334.Thu, Oct 16, 4:45 AM
reviewbot added a comment.Thu, Oct 16, 6:01 AM

Code analysis found 2 defects in diff 1139334:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1139334.

Harbormaster failed remote builds in B861241: Diff 1139334!Thu, Oct 16, 6:01 AM
gl updated this revision to Diff 1140923.Sat, Oct 18, 4:19 PM
reviewbot added a comment.Sat, Oct 18, 5:33 PM

Code analysis found 2 defects in diff 1140923:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1140923.

Harbormaster failed remote builds in B862507: Diff 1140923!Sat, Oct 18, 5:33 PM
gl updated this revision to Diff 1141050.Mon, Oct 20, 5:20 AM
reviewbot added a comment.Mon, Oct 20, 6:17 AM

Code analysis found 2 defects in diff 1141050:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1141050.

Harbormaster failed remote builds in B862622: Diff 1141050!Mon, Oct 20, 6:17 AM
gl updated this revision to Diff 1143427.Thu, Oct 23, 5:58 AM
reviewbot added a comment.Thu, Oct 23, 6:46 AM

Code analysis found 2 defects in diff 1143427:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1143427.

Harbormaster failed remote builds in B864416: Diff 1143427!Thu, Oct 23, 6:46 AM
gl updated this revision to Diff 1143791.Thu, Oct 23, 3:48 PM
reviewbot added a comment.Thu, Oct 23, 4:40 PM

Code analysis found 2 defects in diff 1143791:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1143791.

Harbormaster failed remote builds in B864680: Diff 1143791!Thu, Oct 23, 4:40 PM
gl updated this revision to Diff 1144924.Sun, Oct 26, 2:59 AM
gl updated this revision to Diff 1145917.Tue, Oct 28, 2:44 PM
gl updated this revision to Diff 1145934.
Harbormaster failed remote builds in B866303: Diff 1145917!Tue, Oct 28, 3:32 PM
reviewbot added a comment.Tue, Oct 28, 3:33 PM

Code analysis found 2 defects in diff 1145934:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1145934.

Harbormaster failed remote builds in B866320: Diff 1145934!Tue, Oct 28, 3:34 PM
gl updated this revision to Diff 1147748.Thu, Oct 30, 8:39 PM
reviewbot added a comment.Thu, Oct 30, 9:36 PM

Code analysis found 2 defects in diff 1147748:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1147748.

Harbormaster failed remote builds in B867727: Diff 1147748!Thu, Oct 30, 9:36 PM
gl updated this revision to Diff 1148317.Fri, Oct 31, 4:24 PM
reviewbot added a comment.Fri, Oct 31, 5:33 PM

Code analysis found 2 defects in diff 1148317:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1148317.

Harbormaster failed remote builds in B868188: Diff 1148317!Fri, Oct 31, 5:33 PM
gl updated this revision to Diff 1148847.Mon, Nov 3, 7:04 AM
reviewbot added a comment.Mon, Nov 3, 8:01 AM

Code analysis found 2 defects in diff 1148847:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1148847.

Harbormaster failed remote builds in B868662: Diff 1148847!Mon, Nov 3, 8:01 AM
gl updated this revision to Diff 1149359.Mon, Nov 3, 7:55 PM
gl updated this revision to Diff 1151097.Thu, Nov 6, 5:13 AM
reviewbot added a comment.Thu, Nov 6, 6:05 AM

Code analysis found 2 defects in diff 1151097:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1151097.

Harbormaster failed remote builds in B870498: Diff 1151097!Thu, Nov 6, 6:05 AM
gl updated this revision to Diff 1151998.Fri, Nov 7, 2:57 PM
reviewbot added a comment.Fri, Nov 7, 4:18 PM

Code analysis found 2 defects in diff 1151998:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1151998.

Harbormaster failed remote builds in B871288: Diff 1151998!Fri, Nov 7, 4:19 PM
gl updated this revision to Diff 1152495.Sun, Nov 9, 3:28 AM
reviewbot added a comment.Sun, Nov 9, 4:34 AM

Code analysis found 2 defects in diff 1152495:

  • 2 defects found by android-fenix (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1152495.

Harbormaster failed remote builds in B871744: Diff 1152495!Sun, Nov 9, 4:34 AM

Revision Contents
Changeset List

PathSize
mobile/
android/
fenix/
app/
src/
main/
java/
org/
mozilla/
fenix/
home/
9 lines
res/
layout/
2 lines
values/
1 line
2 lines

Diff 1152495

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/res/layout/fragment_home.xml

Loading...
View Options

mobile/android/fenix/app/src/main/res/values/attrs.xml

Loading...
View Options

mobile/android/fenix/app/src/main/res/values/styles.xml

Loading...
Privacy · Cookies · Legal