Page MenuHomePhabricator
Differential D270639

Bug 1983833 - Part 7: Migrate DotHighlight to use M3 Acorn color tokens
AcceptedPublic
Actions

Authored by gl on Thu, Oct 30, 5:33 AM.

Details

Reviewers
007
petru
Group Reviewers
android-reviewers
Bugzilla Bug ID
1983833
Summary

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Event Timeline

gl created this revision.Thu, Oct 30, 5:33 AM
Herald added a project: secure-revision. · View Herald TranscriptThu, Oct 30, 5:33 AM
gl added a child revision: D270640: Bug 1983833 - Part 8: Migrate ActionButton and ActionContainer to use M3 Acorn color tokens.Thu, Oct 30, 5:33 AM
phab-bot published this revision for review.Thu, Oct 30, 5:33 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a reviewer: android-reviewers. · View Herald TranscriptThu, Oct 30, 5:33 AM
gl added reviewers: 007, petru.Thu, Oct 30, 5:34 AM
Harbormaster failed remote builds in B867266: Diff 1147175!Thu, Oct 30, 5:35 AM
petru accepted this revision.Thu, Oct 30, 2:21 PM
petru added a project: testing-exception-ui (Only changes ui styling, images, or localized strings).

LGTM, thanks!

This revision is now accepted and ready to land.Thu, Oct 30, 2:21 PM
gl updated this revision to Diff 1147770.Thu, Oct 30, 8:40 PM
reviewbot added a subscriber: reviewbot.Thu, Oct 30, 9:44 PM

Code analysis found 1 defect in diff 1147770:

  • 1 defect found by android-fenix (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1147770.

Harbormaster failed remote builds in B867749: Diff 1147770!Thu, Oct 30, 9:44 PM
gl updated this revision to Diff 1148335.Fri, Oct 31, 4:25 PM
reviewbot added a comment.Fri, Oct 31, 5:28 PM

Code analysis found 1 defect in diff 1148335:

  • 1 defect found by android-fenix (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1148335.

Harbormaster failed remote builds in B868206: Diff 1148335!Fri, Oct 31, 5:28 PM
007 added a subscriber: jdelorenzo.Fri, Oct 31, 10:09 PM
007 added inline comments.
mobile/android/android-components/components/compose/browser-toolbar/src/main/java/mozilla/components/compose/browser/toolbar/ui/DotHighlight.kt
26

this component + behavior looks similar to a Badge but without text

https://www.figma.com/design/MjufE1X5fvkxZ0YneX4kRd/Android-Library--2025-?node-id=55141-14167&p=f&m=dev

@jdelorenzo - can you double check this component and see if it can be replaced with your work?

Bug 1994783

gl updated this revision to Diff 1148865.Mon, Nov 3, 7:05 AM
reviewbot added a comment.Mon, Nov 3, 8:02 AM

Code analysis found 1 defect in diff 1148865:

  • 1 defect found by android-fenix (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1148865.

Harbormaster failed remote builds in B868680: Diff 1148865!Mon, Nov 3, 8:02 AM
gl updated this revision to Diff 1149376.Mon, Nov 3, 7:56 PM
Harbormaster failed remote builds in B869115: Diff 1149376!Mon, Nov 3, 7:57 PM
gl updated this revision to Diff 1151114.Thu, Nov 6, 5:14 AM
Harbormaster failed remote builds in B870515: Diff 1151114!Thu, Nov 6, 5:27 AM
gl updated this revision to Diff 1152015.Fri, Nov 7, 2:58 PM
reviewbot added a comment.Fri, Nov 7, 4:06 PM

Code analysis found 1 defect in diff 1152015:

  • 1 defect found by android-fenix (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1152015.

Harbormaster failed remote builds in B871305: Diff 1152015!Fri, Nov 7, 4:08 PM
gl updated this revision to Diff 1152512.Sun, Nov 9, 3:29 AM
reviewbot added a comment.Sun, Nov 9, 4:39 AM

Code analysis found 1 defect in diff 1152512:

  • 1 defect found by android-fenix (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1152512.

Harbormaster failed remote builds in B871761: Diff 1152512!Sun, Nov 9, 4:39 AM

Revision Contents
Changeset List

PathSize
mobile/
android/
android-components/
components/
compose/
base/
src/
main/
java/
mozilla/
components/
compose/
base/
theme/
19 lines
browser-toolbar/
src/
main/
java/
mozilla/
components/
compose/
browser/
toolbar/
ui/
17 lines

Diff 1152512

View Options

mobile/android/android-components/components/compose/base/src/main/java/mozilla/components/compose/base/theme/AcornColors.kt

Loading...
View Options

mobile/android/android-components/components/compose/browser-toolbar/src/main/java/mozilla/components/compose/browser/toolbar/ui/DotHighlight.kt

Loading...
Privacy · Cookies · Legal