Skip to content

Conversation

@abravalheri
Copy link
Contributor

@abravalheri abravalheri commented May 12, 2025

Summary of changes

Fix the error in https://github.com/pypa/setuptools/actions/runs/14977076299/job/42072003260?pr=4994#step:11:155

(test (3.13, windows-latest))

image

Pull Request Checklist

@abravalheri abravalheri marked this pull request as ready for review May 12, 2025 16:53
@abravalheri
Copy link
Contributor Author

It seems that joinpath is the intended method name: https://github.com/python/cpython/blob/3.11/Lib/importlib/resources/abc.py#L99

So I will go ahead with this change.

@abravalheri abravalheri merged commit 75fd24e into pypa:main May 13, 2025
20 of 24 checks passed
@abravalheri abravalheri deleted the windows-errors branch May 13, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant