Skip to content

Conversation

@abravalheri
Copy link
Contributor

@abravalheri abravalheri commented May 19, 2025

Summary of changes

With the changes introduced in ae480ff, the dependency on coherent.licensed is unused, so I think it would be good to remove it for clean-up purposes1.

The approach I took here was to simply comment out the line, because I notice that is the approach previously used in #4975, but I can also simply remove all the requires and put an empty array if that is preferred.

Closes #5002

Pull Request Checklist

Footnotes

  1. The removal should speed up build and facilitate for downstream consumers building from git repos instead of sdists.
    I understand that in the long run it would be nice to have a solution for the cycles, but for now because we are not using the dependency, there is not much point in keep it around.

@abravalheri abravalheri changed the title Issue 5002 Remove unused dependency on coherent.licensed May 19, 2025
@abravalheri abravalheri marked this pull request as ready for review May 19, 2025 12:00
@abravalheri abravalheri requested a review from jaraco May 19, 2025 12:00
@jaraco
Copy link
Member

jaraco commented May 19, 2025

Thanks Anderson for this. See my note in the issue for why I'm hesitant to simply remove the dependency.

@jaraco
Copy link
Member

jaraco commented May 20, 2025

Let's go ahead and apply this change here (only) for now to alleviate the concern for now.

@jaraco jaraco merged commit 9179b75 into pypa:main May 20, 2025
22 of 24 checks passed
@abravalheri abravalheri deleted the issue-5002 branch May 20, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please drop the coherent.licensed dependency

3 participants