Fix HTMLCollection iteration to make unhide function work as expected (#4051)

eunchan-park · boneskull · commit 954cf0b821c3 · 2019-10-18T14:51:51.000-04:00
diff --git a/lib/reporters/html.js b/lib/reporters/html.js
@@ -357,8 +357,8 @@ function hideSuitesWithout(classname) {
  */
 function unhide() {
   var els = document.getElementsByClassName('suite hidden');
-  for (var i = 0; i < els.length; ++i) {
-    els[i].className = els[i].className.replace('suite hidden', 'suite');
+  while (els.length > 0) {
+    els[0].className = els[0].className.replace('suite hidden', 'suite');
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -357,8 +357,8 @@ function hideSuitesWithout(classname) {`
`357`	`357`	`*/`
`358`	`358`	`function unhide() {`
`359`	`359`	`var els = document.getElementsByClassName('suite hidden');`
`360`		`- for (var i = 0; i < els.length; ++i) {`
`361`		`- els[i].className = els[i].className.replace('suite hidden', 'suite');`
	`360`	`+ while (els.length > 0) {`
	`361`	`+ els[0].className = els[0].className.replace('suite hidden', 'suite');`
`362`	`362`	`}`
`363`	`363`	`}`
`364`	`364`