From: Ashutosh B. <ash...@en...> - 2012-03-27 04:27:16
|
For this patch this is it. The old FQS code, which is dead now, is scattered at quite a few places. Somehow the dead code is defined in such a way, that it doesn't show as warnings in unused code. So, I just clean it up whenever I see one. Hopefully, there is not much left now. On Tue, Mar 27, 2012 at 6:02 AM, Michael Paquier <mic...@gm...>wrote: > > > On Mon, Mar 26, 2012 at 7:09 PM, Ashutosh Bapat < > ash...@en...> wrote: > >> Hi All, >> >> PFA patch with some more things cleaned up. I do not see any new failures >> in the regression. >> > Looks good. Is it the last patch you are planning to do or will you add > smth else? > >> >> On Mon, Mar 12, 2012 at 12:18 PM, Ashutosh Bapat < >> ash...@en...> wrote: >> >>> Hi All, >>> PFA patch for more cleanup. >>> >>> With the new FQS code, we don't create child plans beneath RemoteQuery >>> node. Now RemoteQuery node should be leaf node in plan tree. I also removed >>> member tts_dataNodeIndex from TupleTableSlot. >>> >>> Regression ran without any new failures. >>> >>> On Fri, Mar 9, 2012 at 5:22 AM, Michael Paquier < >>> mic...@gm...> wrote: >>> >>>> >>>> >>>> On Thu, Mar 8, 2012 at 8:13 PM, Ashutosh Bapat < >>>> ash...@en...> wrote: >>>> >>>>> Hi All, >>>>> PFA patch for cleanup of dead-code. There are many functions and >>>>> structure members, which are not used by the new FQS code. Removed them. >>>>> >>>>> Regression does not show any new error. >>>>> >>>> This patch looks good, but it is not realigned with the latest head. >>>> Could you realign it? >>>> Except that, the content looks OK. >>>> -- >>>> Michael Paquier >>>> http://michael.otacoo.com >>>> >>> >>> >>> >>> -- >>> Best Wishes, >>> Ashutosh Bapat >>> EntepriseDB Corporation >>> The Enterprise Postgres Company >>> >>> >> >> >> -- >> Best Wishes, >> Ashutosh Bapat >> EntepriseDB Corporation >> The Enterprise Postgres Company >> >> > > > -- > Michael Paquier > http://michael.otacoo.com > -- Best Wishes, Ashutosh Bapat EntepriseDB Corporation The Enterprise Postgres Company |