Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: grpc/grpc-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.38.0
Choose a base ref
...
head repository: grpc/grpc-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.38.1
Choose a head ref
  • 5 commits
  • 29 files changed
  • 3 contributors

Commits on May 18, 2021

  1. Configuration menu
    Copy the full SHA
    f9c6d5e View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Configuration menu
    Copy the full SHA
    419c191 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. grpclb: skip fallback if the LB is already in fallback mode (backport…

    … v1.38.x) (#8253) (#8259)
    
    Manually checks if the gRPCLB policy is already in fallback mode when trying to fallback due to receiving address update without LB addresses. 
    
    Commit b956f88 added an invariant check in the FallbackModeTask runnable to ensure the task is fired only when the LB is not already in fallback mode. However, that commit missed the case that receiving address updates without LB addresses can trigger the run of FallbackModeTask runnable, because the existing implementation chose to reuse the code in FallbackModeTask. In such case, running FallbackModeTask could break the invariant check as the LB policy may already in fallback mode.
    
    This change eliminates the reuse of FallbackModeTask for handling address update without LB address. That is, every time receiving address update, we manually check if it is already in fallback instead of reusing to FallbackModeTask perform the check.
    
    Note there was a discussion brought up whether we should force entering fallback (shutdown existing subchannels) or we should still keep the balancer connection. Different languages have already diverged on this. Go shuts down the balancer connection and all subchannel connections to force using fallback addresses. C-core keep the balancer connection working and does not shutdown subchannels, only let fallback happens after the existing balancer connection and subchannel connections become broken. Java shuts down the balancer connection but not subchannels. This change does not try to change the existing behavior, but only fixes the invariant check breakage.
    
    -------------------
    See bug reported in  b/190700476
    Backport of #8253
    voidzcy authored Jun 15, 2021
    Configuration menu
    Copy the full SHA
    3da41a4 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Configuration menu
    Copy the full SHA
    37b99a5 View commit details
    Browse the repository at this point in the history
  2. Bump version to 1.38.1

    voidzcy committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    6cb4d90 View commit details
    Browse the repository at this point in the history
Loading