Skip to content

api: Document that NameResolvers shouldn't block #8398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2021
Merged

api: Document that NameResolvers shouldn't block #8398

merged 1 commit into from
Aug 9, 2021

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Aug 9, 2021

Fixes #8190

@ejona86 ejona86 requested a review from sanjaypujare August 9, 2021 23:11
sanjaypujare
sanjaypujare reviewed Aug 9, 2021
View reviewed changes
sanjaypujare
sanjaypujare approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86 ejona86 merged commit 51d1484 into grpc:master Aug 9, 2021
@ejona86 ejona86 deleted the nr-dont-block branch August 9, 2021 23:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@sanjaypujare sanjaypujare sanjaypujare approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grpc hang due to the ELG thread placement of NameResolver refresh method
2 participants
@ejona86 @sanjaypujare