Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/gax-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.59.0
Choose a base ref
...
head repository: googleapis/gax-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.59.1
Choose a head ref
  • 5 commits
  • 18 files changed
  • 4 contributors

Commits on Sep 30, 2020

  1. fix: update owners file with actools-java (#1194)

    @miraleung
    miraleung authored Sep 30, 2020
    Configuration menu
    Copy the full SHA
    9977dd2 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. build: fetch release notification secrets from secret manager (#1196)

    @chingor13
    chingor13 authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    0976e20 View commit details
    Browse the repository at this point in the history

  2. fix: Fix race condition in BatcherImpl flush (#1200) 

    * fix: Fix race condition in BatcherImpl flush

Currently the following race condition exists:

T1 - awaitAllOutstandingBatches checks that numOfOutstandingBatches > 0
T2 - onBatchCompletion decrements numOfOutstandingBatches
T2 - flushLock.notifyAll()
T1 - flushLock.wait()

so T1 will wait indefinitely

The fix is quite simple: make sure that the there batches to wait for after acquiring the lock

* add test
    @igorbernstein2
    igorbernstein2 authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    c6308c9 View commit details
    Browse the repository at this point in the history

  3. chore: release 1.59.1-SNAPSHOT (#1195) 

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Mira Leung <[email protected]>
    @release-please @miraleung
    release-please[bot] and miraleung authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    e6a7cf3 View commit details
    Browse the repository at this point in the history

  4. chore: release 1.59.1 (#1202) 

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    @release-please
    release-please[bot] authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    f30b659 View commit details
    Browse the repository at this point in the history
Loading