fix: reuse clientId for invalidated databases#206

Merged

skuruppu merged 2 commits intomasterfrom

reuse-client-id-for-invalidated-dbs

May 15, 2020

Collaborator

olavloite commented May 13, 2020

A new client id would be generated each time a DatabaseClient was requested for a non-existing database. This change ensures that the same client id will be re-used for a DatabaseClient that has been created by a Spanner instance, also after it has been invalidated.

Fixes #202

googlebot added the cla: yes label

olavloite added the kokoro:force-run label

yoshi-kokoro removed the kokoro:force-run label

olavloite added 2 commits

May 14, 2020 08:47


          fix: reuse clientId for invalidated databases

7b24a4f


          formatting: run code formatter

c9ba71a

olavloite force-pushed the reuse-client-id-for-invalidated-dbs branch from a1499c6 to c9ba71a Compare

May 14, 2020 06:49

olavloite requested a review from skuruppu

May 14, 2020 07:20

skuruppu approved these changes

View reviewed changes

skuruppu merged commit 7b4490d into master

skuruppu deleted the reuse-client-id-for-invalidated-dbs branch

May 15, 2020 03:45

sebright2 mentioned this pull request

Attempting to read from a non-existent database can create many distinct client IDs in the session metrics #202

Closed

gcf-merge-on-green bot pushed a commit that referenced this pull request


          chore: release 1.55.0 (#211)

2e533b7

🤖 I have created a release \*beep\* \*boop\* 
---
## [1.55.0](https://www.github.com/googleapis/java-spanner/compare/v1.54.0...v1.55.0) (2020-05-19)


### Features

* mark when a Spanner client is closed ([#198](https://www.github.com/googleapis/java-spanner/issues/198)) ([50cb174](https://www.github.com/googleapis/java-spanner/commit/50cb1744e7ede611758d3ff63b3df77a1d3682eb))


### Bug Fixes

* make it possible to override backups methods ([#195](https://www.github.com/googleapis/java-spanner/issues/195)) ([2d19c25](https://www.github.com/googleapis/java-spanner/commit/2d19c25ba32847d116194565e67e1b1276fcb9f8))
* Partitioned DML timeout was not always respected ([#203](https://www.github.com/googleapis/java-spanner/issues/203)) ([13cb37e](https://www.github.com/googleapis/java-spanner/commit/13cb37e55ddfd1ff4ec22b1dcdc20c4832eee444)), closes [#199](https://www.github.com/googleapis/java-spanner/issues/199)
* partitionedDml stub was not closed ([#213](https://www.github.com/googleapis/java-spanner/issues/213)) ([a2d9a33](https://www.github.com/googleapis/java-spanner/commit/a2d9a33fa31f7467fc2bfbef5a29c4b3f5aea7c8))
* reuse clientId for invalidated databases ([#206](https://www.github.com/googleapis/java-spanner/issues/206)) ([7b4490d](https://www.github.com/googleapis/java-spanner/commit/7b4490dfb61fbc81b5bd6be6c9a663b36b5ce402))
* use nanos to prevent truncation errors ([#204](https://www.github.com/googleapis/java-spanner/issues/204)) ([a608460](https://www.github.com/googleapis/java-spanner/commit/a60846043dc0ca47e1970d8ab99380b6d725c7a9)), closes [#200](https://www.github.com/googleapis/java-spanner/issues/200)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.3.1 ([#190](https://www.github.com/googleapis/java-spanner/issues/190)) ([ad41a0d](https://www.github.com/googleapis/java-spanner/commit/ad41a0d4b0cc6a2c0ae0611c767652f64cfb2fb7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).

ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request


          all: run vet (googleapis#206)

455060b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels