fix: safeguard against statement errors when requesting a transaction#800
Merged
thiagotnunes merged 1 commit intomasterfrom Jan 14, 2021
Merged
fix: safeguard against statement errors when requesting a transaction#800thiagotnunes merged 1 commit intomasterfrom
thiagotnunes merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
============================================
+ Coverage 85.01% 85.09% +0.08%
- Complexity 2562 2564 +2
============================================
Files 143 143
Lines 14015 14030 +15
Branches 1341 1341
============================================
+ Hits 11915 11939 +24
+ Misses 1537 1531 -6
+ Partials 563 560 -3
Continue to review full report at Codecov.
|
thiagotnunes
approved these changes
Jan 14, 2021
Contributor
thiagotnunes
left a comment
There was a problem hiding this comment.
Thanks for this fixes @olavloite, really appreciate it.
thiagotnunes
pushed a commit
that referenced
this pull request
May 6, 2021
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#5930 Changes: docs(servicemanagement): fix remaining broken links PiperOrigin-RevId: 443508623 Source-Link: googleapis/googleapis@fd6935f feat(channel): Add new enum value, new filter in ListCustomersRequest of Cloud Channel API PiperOrigin-RevId: 443474187 Source-Link: googleapis/googleapis@d4dd268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a number of safeguards against hanging transactions if the first statement of a transaction for whatever reason fails to return a transaction ID, or otherwise returns an unexpected error. This PR contains the following safeguards:
Throwablethat is not aSpannerException), the exception will be translated to aSpannerExceptionand handled as such. This error will mark the transaction as unusable, as the first statement failed to return a transaction.ABORTEDerror. This will cause the transaction to be retried automatically.Fixes #799