Skip to content

fix: fix id_or_name property of key class #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crwilcox merged 3 commits into from
Nov 13, 2020
Merged

fix: fix id_or_name property of key class #115

crwilcox merged 3 commits into from
Nov 13, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Nov 9, 2020

Fixes #106

@HemangChothani HemangChothani requested review from a team, crwilcox and tseaver November 9, 2020 10:39
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Nov 9, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2020
@chrisrossi
Copy link
Contributor

chrisrossi commented Nov 9, 2020

Does Datastore let you store a key with id of 0?

@HemangChothani
Copy link
Contributor Author

HemangChothani commented Nov 10, 2020 •
edited
Loading

@chrisrossi Library doesn't raise an error when passing id =0 but if id is 0, generate automatically as mentioned in document here

@chrisrossi
Copy link
Contributor

chrisrossi commented Nov 10, 2020

@chrisrossi Library doesn't raise an error when passing id =0 but if id is 0, generate automatically as mentioned in document here

Fair enough! This looks good to me, but I would probably add a regression test.

tseaver
tseaver suggested changes Nov 11, 2020
View reviewed changes
@tseaver
Copy link
Contributor

tseaver commented Nov 13, 2020

@crwilcox, @czahedi Again, the requiresCodeOwnerReviews: true policy means my approval is not sufficient to merge this PR.

@crwilcox crwilcox merged commit 6f28b84 into googleapis:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/python-datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

datastore Key id_or_name() returns None when id is 0

4 participants

@HemangChothani @chrisrossi @tseaver @crwilcox