Skip to content
This repository was archived by the owner on Jul 6, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/python-network-connectivity
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.0
Choose a base ref
...
head repository: googleapis/python-network-connectivity
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.1
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Sep 30, 2021

  1. chore: use gapic-generator-python 0.52.0 (#84)

    - [ ] Regenerate this pull request now.
    
    fix: improper types in pagers generation
    PiperOrigin-RevId: 399773015
    
    Source-Link: googleapis/googleapis@410c184
    
    Source-Link: https://github.com/googleapis/googleapis-gen/commit/290e883545e3ac9ff2bd00cd0dacb28f1b8ca945
    Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwZTg4MzU0NWUzYWM5ZmYyYmQwMGNkMGRhY2IyOGYxYjhjYTk0NSJ9
    gcf-owl-bot[bot] authored Sep 30, 2021
    Copy the full SHA
    b83e28b View commit details
  2. Copy the full SHA
    405a750 View commit details
Showing with 28 additions and 21 deletions.
  1. +7 −0 CHANGELOG.md
  2. +10 −10 google/cloud/networkconnectivity_v1/services/hub_service/pagers.py
  3. +10 −10 google/cloud/networkconnectivity_v1alpha1/services/hub_service/pagers.py
  4. +1 −1 setup.py
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

### [1.0.1](https://www.github.com/googleapis/python-network-connectivity/compare/v1.0.0...v1.0.1) (2021-09-30)


### Bug Fixes

* improper types in pagers generation ([b83e28b](https://www.github.com/googleapis/python-network-connectivity/commit/b83e28b9c810c3bb4b1e2a7a88aff72f6b8afe36))

## [1.0.0](https://www.github.com/googleapis/python-network-connectivity/compare/v0.6.1...v1.0.0) (2021-09-29)


20 changes: 10 additions & 10 deletions google/cloud/networkconnectivity_v1/services/hub_service/pagers.py
Original file line number Diff line number Diff line change
@@ -15,13 +15,13 @@
#
from typing import (
Any,
AsyncIterable,
AsyncIterator,
Awaitable,
Callable,
Iterable,
Sequence,
Tuple,
Optional,
Iterator,
)

from google.cloud.networkconnectivity_v1.types import hub
@@ -74,14 +74,14 @@ def __getattr__(self, name: str) -> Any:
return getattr(self._response, name)

@property
def pages(self) -> Iterable[hub.ListHubsResponse]:
def pages(self) -> Iterator[hub.ListHubsResponse]:
yield self._response
while self._response.next_page_token:
self._request.page_token = self._response.next_page_token
self._response = self._method(self._request, metadata=self._metadata)
yield self._response

def __iter__(self) -> Iterable[hub.Hub]:
def __iter__(self) -> Iterator[hub.Hub]:
for page in self.pages:
yield from page.hubs

@@ -136,14 +136,14 @@ def __getattr__(self, name: str) -> Any:
return getattr(self._response, name)

@property
async def pages(self) -> AsyncIterable[hub.ListHubsResponse]:
async def pages(self) -> AsyncIterator[hub.ListHubsResponse]:
yield self._response
while self._response.next_page_token:
self._request.page_token = self._response.next_page_token
self._response = await self._method(self._request, metadata=self._metadata)
yield self._response

def __aiter__(self) -> AsyncIterable[hub.Hub]:
def __aiter__(self) -> AsyncIterator[hub.Hub]:
async def async_generator():
async for page in self.pages:
for response in page.hubs:
@@ -202,14 +202,14 @@ def __getattr__(self, name: str) -> Any:
return getattr(self._response, name)

@property
def pages(self) -> Iterable[hub.ListSpokesResponse]:
def pages(self) -> Iterator[hub.ListSpokesResponse]:
yield self._response
while self._response.next_page_token:
self._request.page_token = self._response.next_page_token
self._response = self._method(self._request, metadata=self._metadata)
yield self._response

def __iter__(self) -> Iterable[hub.Spoke]:
def __iter__(self) -> Iterator[hub.Spoke]:
for page in self.pages:
yield from page.spokes

@@ -264,14 +264,14 @@ def __getattr__(self, name: str) -> Any:
return getattr(self._response, name)

@property
async def pages(self) -> AsyncIterable[hub.ListSpokesResponse]:
async def pages(self) -> AsyncIterator[hub.ListSpokesResponse]:
yield self._response
while self._response.next_page_token:
self._request.page_token = self._response.next_page_token
self._response = await self._method(self._request, metadata=self._metadata)
yield self._response

def __aiter__(self) -> AsyncIterable[hub.Spoke]:
def __aiter__(self) -> AsyncIterator[hub.Spoke]:
async def async_generator():
async for page in self.pages:
for response in page.spokes:
Original file line number Diff line number Diff line change
@@ -15,13 +15,13 @@
#
from typing import (
Any,
AsyncIterable,
AsyncIterator,
Awaitable,
Callable,
Iterable,
Sequence,
Tuple,
Optional,
Iterator,
)

from google.cloud.networkconnectivity_v1alpha1.types import hub
@@ -74,14 +74,14 @@ def __getattr__(self, name: str) -> Any:
return getattr(self._response, name)

@property
def pages(self) -> Iterable[hub.ListHubsResponse]:
def pages(self) -> Iterator[hub.ListHubsResponse]:
yield self._response
while self._response.next_page_token:
self._request.page_token = self._response.next_page_token
self._response = self._method(self._request, metadata=self._metadata)
yield self._response

def __iter__(self) -> Iterable[hub.Hub]:
def __iter__(self) -> Iterator[hub.Hub]:
for page in self.pages:
yield from page.hubs

@@ -136,14 +136,14 @@ def __getattr__(self, name: str) -> Any:
return getattr(self._response, name)

@property
async def pages(self) -> AsyncIterable[hub.ListHubsResponse]:
async def pages(self) -> AsyncIterator[hub.ListHubsResponse]:
yield self._response
while self._response.next_page_token:
self._request.page_token = self._response.next_page_token
self._response = await self._method(self._request, metadata=self._metadata)
yield self._response

def __aiter__(self) -> AsyncIterable[hub.Hub]:
def __aiter__(self) -> AsyncIterator[hub.Hub]:
async def async_generator():
async for page in self.pages:
for response in page.hubs:
@@ -202,14 +202,14 @@ def __getattr__(self, name: str) -> Any:
return getattr(self._response, name)

@property
def pages(self) -> Iterable[hub.ListSpokesResponse]:
def pages(self) -> Iterator[hub.ListSpokesResponse]:
yield self._response
while self._response.next_page_token:
self._request.page_token = self._response.next_page_token
self._response = self._method(self._request, metadata=self._metadata)
yield self._response

def __iter__(self) -> Iterable[hub.Spoke]:
def __iter__(self) -> Iterator[hub.Spoke]:
for page in self.pages:
yield from page.spokes

@@ -264,14 +264,14 @@ def __getattr__(self, name: str) -> Any:
return getattr(self._response, name)

@property
async def pages(self) -> AsyncIterable[hub.ListSpokesResponse]:
async def pages(self) -> AsyncIterator[hub.ListSpokesResponse]:
yield self._response
while self._response.next_page_token:
self._request.page_token = self._response.next_page_token
self._response = await self._method(self._request, metadata=self._metadata)
yield self._response

def __aiter__(self) -> AsyncIterable[hub.Spoke]:
def __aiter__(self) -> AsyncIterator[hub.Spoke]:
async def async_generator():
async for page in self.pages:
for response in page.spokes:
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@
import os
import setuptools # type: ignore

version = "1.0.0"
version = "1.0.1"

package_root = os.path.abspath(os.path.dirname(__file__))