Skip to content

Commit 7100b2b

Browse files
feat: Support WMA files, including those with embedded album art (#143)
The tag library supports WMA, so add the mimetype. Some wma files have embedded album art encoded as a video stream alongside the audio: ``` Input #0, asf, from '01. Emergency Pulloff.wma': Metadata: (snip) Duration: 00:03:11.47, start: 0.000000, bitrate: 129 kb/s Stream #0:0: Video: mjpeg, yuvj420p(pc, bt470bg/unknown/unknown), 200x200 [SAR 96:96 DAR 1:1], 90k tbr, 90k tbn, 90k tbc Metadata: comment : Cover (front) Stream #0:1: Audio: wmav2 (a[1][0][0] / 0x0161), 44100 Hz, stereo, fltp, 128 kb/s Output #0, opus, to '/tmp/output.opus': Output file #0 does not contain any stream ``` The `-map 0:0` passed to ffmpeg is selecting the video stream to transcode, then `-vn` says not to transcode video, so the whole process returns an error code: ``` 2021/05/28 18:59:09 transcoding according to transcoding profile of 96k 2021/05/28 18:59:09 serving transcode `02. Cotton Patch Rag.wma`: cache [opus/96k] miss! 2021/05/28 18:59:09 serving transcode `02. Cotton Patch Rag.wma`: error: starting transcode: running ffmpeg: exit status 1 ``` I believe the correct solution here is to use an _audio_ stream specifier, as in `-map 0:a:0`. Doing this selects the audio and successfully performs the transcode.
1 parent 6f26974 commit 7100b2b

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

server/encode/encode.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ func ffmpegCommand(filePath string, profile Profile) (*exec.Cmd, error) {
8888
args := []string{
8989
"-v", "0",
9090
"-i", filePath,
91-
"-map", "0:0",
91+
"-map", "0:a:0",
9292
"-vn",
9393
"-b:a", fmt.Sprintf("%dk", profile.Bitrate),
9494
}

server/mime/mime.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ func FromExtension(ext string) (string, bool) {
1212
"m4b": "audio/m4b",
1313
"ogg": "audio/ogg",
1414
"opus": "audio/ogg",
15+
"wma": "audio/x-ms-wma",
1516
}
1617
v, ok := types[ext]
1718
return v, ok

0 commit comments

Comments
 (0)