Patch for migration of the pg_commit_ts directory

Lists: pgsql-hackers
From: ls7777 <ls7777(at)yandex(dot)ru>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Patch for migration of the pg_commit_ts directory
Date: 2025-04-03 18:27:32
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-hackers




Good afternoon!


During pg_upgrade migration, the pg_commit_ts directory is not copied when track_commit_timestamp = on is set. There is a patch in the attachment that fixes this.



 


Contents & Purpose


==================


The patch copies the pg_commit_ts directory of the old cluster and updates the Latest checkpoints oldestCommitTsXid and Latest checkpoint's newestCommitTsXid for the new cluster. If required.


 


Initial Run


===========


The patch can be applied on the master branch.


I don't understand what tests are needed for such a patch. The patch is very simple.


 Performance


===========


The pg_upgrade operation time increases by the time the pg_commit_ts catalog is copied.


 


 

Attachment Content-Type Size
unknown_filename text/html 888 bytes
v1-0001-Migration-of-the-pg_commit_ts-directory.patch text/x-diff 3.4 KB