| Lists: | pgsql-hackers |
|---|
| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Add const qualifiers |
| Date: | 2023-09-01 15:39:24 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hackers,
I noticed that there was a mismatch between the const qualifiers for
excludeDirContents in src/backend/backup/backup/basebackup.c and
src/bin/pg_rewind/file_map.c and that led me to use ^static const.*\*.*=
to do a quick search for similar cases.
I think at the least we should make excludeDirContents match, but the
rest of the changes seem like a good idea as well.
Regards,
-David
| Attachment | Content-Type | Size |
|---|---|---|
| v01-0001-add-const-decorations.patch | text/plain | 7.1 KB |
| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add const qualifiers |
| Date: | 2023-09-09 20:03:37 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 9/1/23 11:39, David Steele wrote:
> Hackers,
>
> I noticed that there was a mismatch between the const qualifiers for
> excludeDirContents in src/backend/backup/backup/basebackup.c and
> src/bin/pg_rewind/file_map.c and that led me to use ^static const.*\*.*=
> to do a quick search for similar cases.
>
> I think at the least we should make excludeDirContents match, but the
> rest of the changes seem like a good idea as well.
Added to 2023-11 CF.
Regards,
-David
| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add const qualifiers |
| Date: | 2023-09-26 10:34:34 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 09.09.23 21:03, David Steele wrote:
> On 9/1/23 11:39, David Steele wrote:
>> Hackers,
>>
>> I noticed that there was a mismatch between the const qualifiers for
>> excludeDirContents in src/backend/backup/backup/basebackup.c and
>> src/bin/pg_rewind/file_map.c and that led me to use ^static
>> const.*\*.*= to do a quick search for similar cases.
>>
>> I think at the least we should make excludeDirContents match, but the
>> rest of the changes seem like a good idea as well.
>
> Added to 2023-11 CF.
committed
| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add const qualifiers |
| Date: | 2023-09-26 20:19:12 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 9/26/23 06:34, Peter Eisentraut wrote:
> On 09.09.23 21:03, David Steele wrote:
>> On 9/1/23 11:39, David Steele wrote:
>>> Hackers,
>>>
>>> I noticed that there was a mismatch between the const qualifiers for
>>> excludeDirContents in src/backend/backup/backup/basebackup.c and
>>> src/bin/pg_rewind/file_map.c and that led me to use ^static
>>> const.*\*.*= to do a quick search for similar cases.
>>>
>>> I think at the least we should make excludeDirContents match, but the
>>> rest of the changes seem like a good idea as well.
>>
>> Added to 2023-11 CF.
>
> committed
Thank you, Peter!