| Lists: | pgsql-hackers |
|---|
| From: | miyake_kouta <miyake_kouta(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | [PATCH] pgbench: Remove ecnt, a member variable of CState |
| Date: | 2021-02-26 08:39:31 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi.
I created a patch to remove ecnt which is a member variable of CState.
This variable is incremented in some places, but it's not used for any
purpose.
Also, the current pgbench's client abandons processing after hitting
error, so this variable is no need, I think.
Regards
--
Kota Miyake
| Attachment | Content-Type | Size |
|---|---|---|
| remove_ecnt.patch | text/x-diff | 851 bytes |
| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | miyake_kouta <miyake_kouta(at)oss(dot)nttdata(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] pgbench: Remove ecnt, a member variable of CState |
| Date: | 2021-02-26 11:39:25 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, Feb 26, 2021 at 05:39:31PM +0900, miyake_kouta wrote:
> Also, the current pgbench's client abandons processing after hitting error,
> so this variable is no need, I think.
Agreed. Its last use was in 12788ae, as far as I can see. So let's
just cleanup that.
--
Michael
| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | miyake_kouta <miyake_kouta(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] pgbench: Remove ecnt, a member variable of CState |
| Date: | 2021-02-26 19:36:41 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 2021-Feb-26, Michael Paquier wrote:
> On Fri, Feb 26, 2021 at 05:39:31PM +0900, miyake_kouta wrote:
> > Also, the current pgbench's client abandons processing after hitting error,
> > so this variable is no need, I think.
>
> Agreed. Its last use was in 12788ae, as far as I can see. So let's
> just cleanup that.
+1
--
Álvaro Herrera Valdivia, Chile
| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | miyake_kouta <miyake_kouta(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] pgbench: Remove ecnt, a member variable of CState |
| Date: | 2021-02-27 23:06:09 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, Feb 26, 2021 at 04:36:41PM -0300, Alvaro Herrera wrote:
> +1
Thanks, done.
--
Michael
| From: | miyake_kouta <miyake_kouta(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] pgbench: Remove ecnt, a member variable of CState |
| Date: | 2021-03-01 02:32:11 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
2021-02-28 08:06, Michael Paquier wrote:
> On Fri, Feb 26, 2021 at 04:36:41PM -0300, Alvaro Herrera wrote:
>> +1
>
> Thanks, done.
> --
> Michael
Thanks for reviewing and committing this patch!
Regards
--
Kota Miyake