| Lists: | pgsql-hackers |
|---|
| From: | Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Subject: | Test patch for partitionwise join with partitioned tables containing default partition |
| Date: | 2018-06-06 05:56:23 |
| Message-ID: | CAKcux6ky5YeZAY74qSh-ayPZZEQchz092g71iXXbC0+E3xoscA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
As of now partition_join.sql is not having test cases covering cases
where partition table have default partition, attaching a small test
case patch to cover those.
Here is a link of previous discussion :
https://www.postgresql.org/message-id/CAKcux6%3DLO-
XK9G0yLe634%2B0SP2UOn5ksVnmF-OntTBOEEaUGTg%40mail.gmail.com
As found by Thomas, The regression test currently fails with v4 patch
because a
redundant Result node has been removed from a query plan. here is the
updated
v5 patch fixing this.
Thanks & Regards,
Rajkumar Raghuwanshi
QMG, EnterpriseDB Corporation
| Attachment | Content-Type | Size |
|---|---|---|
| partitionwise_join_with_default_partitions_v5.patch | text/x-patch | 6.4 KB |
| From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
|---|---|
| To: | Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Test patch for partitionwise join with partitioned tables containing default partition |
| Date: | 2018-06-06 06:02:13 |
| Message-ID: | CAFjFpRf=jdAYiBuWGnc2kcRaEtuY8fKnW879HPaC4sePAyGh7Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Thanks Rajkumar for starting a new thread. Please update the
commitfest entry as well.
I have marked this entry as ready for committer, so expecting a
committer to take a look at the patch and commit it.
On Wed, Jun 6, 2018 at 11:26 AM, Rajkumar Raghuwanshi
<rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> As of now partition_join.sql is not having test cases covering cases
> where partition table have default partition, attaching a small test
> case patch to cover those.
>
> Here is a link of previous discussion :
> https://www.postgresql.org/message-id/CAKcux6%3DLO-XK9G0yLe634%2B0SP2UOn5ksVnmF-OntTBOEEaUGTg%40mail.gmail.com
>
> As found by Thomas, The regression test currently fails with v4 patch
> because a
> redundant Result node has been removed from a query plan. here is the
> updated
> v5 patch fixing this.
>
> Thanks & Regards,
> Rajkumar Raghuwanshi
> QMG, EnterpriseDB Corporation
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
| From: | Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Test patch for partitionwise join with partitioned tables containing default partition |
| Date: | 2018-06-06 06:33:30 |
| Message-ID: | CAKcux6=AepfoKx-zhr5oX=XSV3s7daEfm_+N1F+Ur8PvqPKwcw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Jun 6, 2018 at 11:32 AM, Ashutosh Bapat <
ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> Thanks Rajkumar for starting a new thread. Please update the
> commitfest entry as well.
>
I have attached new thread in commitfest and detached the old one.
Thanks & Regards,
Rajkumar Raghuwanshi
QMG, EnterpriseDB Corporation
| From: | Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, jdavis(at)postgresql(dot)org |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Test patch for partitionwise join with partitioned tables containing default partition |
| Date: | 2018-07-06 05:51:38 |
| Message-ID: | CAKcux6m0BCWu516nrpVJbDJuGRE2kxv92YtM2xieFA6hU0qUJQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Thanks for commit Jeff. Thanks for review Ashutosh, Thomas.
commit 4513d3a4be0bb7d0141f8b7eaf669a55c08e41b0
Author: Jeff Davis <jdavis(at)postgresql(dot)org>
Date: Thu Jul 5 18:56:12 2018 -0700
Add test for partitionwise join involving default partition.
Author: Rajkumar Raghuwanshi
Reviewed-by: Ashutosh Bapat
Discussion:
https://postgr.es/m/CAKcux6ky5YeZAY74qSh-ayPZZEQchz092g71iXXbC0%2BE3xoscA%40mail.gmail.com
Discussion:
https://postgr.es/m/CAKcux6kOQ85Xtzxu3tM1mR7Vk%3D7Z2e4rG7dL1iMZqPgLMpxQYg%40mail.gmail.com
Thanks & Regards,
Rajkumar Raghuwanshi
QMG, EnterpriseDB Corporation
On Wed, Jun 6, 2018 at 12:03 PM, Rajkumar Raghuwanshi <
rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com> wrote:
> On Wed, Jun 6, 2018 at 11:32 AM, Ashutosh Bapat <
> ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
>
>> Thanks Rajkumar for starting a new thread. Please update the
>> commitfest entry as well.
>>
> I have attached new thread in commitfest and detached the old one.
>
> Thanks & Regards,
> Rajkumar Raghuwanshi
> QMG, EnterpriseDB Corporation
>