| Lists: | pgsql-hackers |
|---|
| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | rename SnapBuild* macros in slot.c |
| Date: | 2021-11-20 14:13:11 |
| Message-ID: | CALj2ACVZo-piDGzBOJRY4ob=_goFR6t9DhZMDMjJWN7LQs34Aw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
It seems like the same macro names for
SnapBuildOnDiskNotChecksummedSize and SnapBuildOnDiskChecksummedSize
are being used in slot.c and snapbuild.c. I think, in slot.c, we can
rename them to ReplicationSlotOnDiskNotChecksummedSize and
ReplicationSlotOnDiskChecksummedSize
similar to the other macros ReplicationSlotOnDiskConstantSize and
ReplicationSlotOnDiskV2Size.
Here's a tiny patch for the above change.
Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-rename-SnapBuild-macros-in-slot.c.patch | application/octet-stream | 2.3 KB |
| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: rename SnapBuild* macros in slot.c |
| Date: | 2021-11-22 11:42:00 |
| Message-ID: | CAA4eK1LPE-3vvN-kHj_ruBOVuVDirtjmKPRUUfQV=H49ua65Ww@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Sat, Nov 20, 2021 at 7:43 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> It seems like the same macro names for
> SnapBuildOnDiskNotChecksummedSize and SnapBuildOnDiskChecksummedSize
> are being used in slot.c and snapbuild.c. I think, in slot.c, we can
> rename them to ReplicationSlotOnDiskNotChecksummedSize and
> ReplicationSlotOnDiskChecksummedSize
> similar to the other macros ReplicationSlotOnDiskConstantSize and
> ReplicationSlotOnDiskV2Size.
>
+1 for this change. This seems to be introduced by commit ec5896aed3
[1] and I think it is just a typo to name these macros starting with
SnapBuildOnDisk* unless I am missing something.
[1]
commit ec5896aed3c01da24c1f335f138817e9890d68b6
Author: Andres Freund <andres(at)anarazel(dot)de>
Date: Wed Nov 12 18:52:49 2014 +0100
Fix several weaknesses in slot and logical replication on-disk
serialization.
--
With Regards,
Amit Kapila.
| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: rename SnapBuild* macros in slot.c |
| Date: | 2021-11-22 14:17:35 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 2021-Nov-22, Amit Kapila wrote:
> +1 for this change. This seems to be introduced by commit ec5896aed3
> [1] and I think it is just a typo to name these macros starting with
> SnapBuildOnDisk* unless I am missing something.
Yeah, it looks pretty weird. +1 for the change on consistency grounds.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: rename SnapBuild* macros in slot.c |
| Date: | 2021-11-23 02:42:18 |
| Message-ID: | CAA4eK1L8UTokKAeB1=OrvFdfX9S_z0Kn45xrTALGqqoz5WZhqw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, Nov 22, 2021 at 7:47 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2021-Nov-22, Amit Kapila wrote:
>
> > +1 for this change. This seems to be introduced by commit ec5896aed3
> > [1] and I think it is just a typo to name these macros starting with
> > SnapBuildOnDisk* unless I am missing something.
>
> Yeah, it looks pretty weird. +1 for the change on consistency grounds.
>
Okay, I will push this tomorrow unless I see any objections.
--
With Regards,
Amit Kapila.
| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: rename SnapBuild* macros in slot.c |
| Date: | 2021-11-24 08:55:49 |
| Message-ID: | CAA4eK1+JfsZpjSTVS3g5TnAk2aBOwCi3JE1QfE4HhURb1J9Cbw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Nov 23, 2021 at 8:12 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Nov 22, 2021 at 7:47 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> >
> > On 2021-Nov-22, Amit Kapila wrote:
> >
> > > +1 for this change. This seems to be introduced by commit ec5896aed3
> > > [1] and I think it is just a typo to name these macros starting with
> > > SnapBuildOnDisk* unless I am missing something.
> >
> > Yeah, it looks pretty weird. +1 for the change on consistency grounds.
> >
>
> Okay, I will push this tomorrow unless I see any objections.
>
Pushed!
--
With Regards,
Amit Kapila.