Skip to content

Updated license badge image src in README.md #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

VampireChicken12
Copy link
Contributor

@VampireChicken12 VampireChicken12 commented Jul 17, 2024

User description

This commit fixes the image src for the license badge.


Description

  • Updated the license badge image src in the README.md file.

Changes walkthrough 📝

Relevant files
Documentation
README.md
Updated license badge image src in README.md                         

README.md
['Updated the license badge image src in the README.md file.']

+1/-1     

@penify-dev penify-dev bot added the documentation Improvements or additions to documentation label Jul 17, 2024
@penify-dev penify-dev bot changed the title docs: fix license badge Updated license badge image src in README.md Jul 17, 2024
Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typed-xlsx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 7:24pm

Copy link
Contributor

penify-dev bot commented Jul 17, 2024

PR Review 🔍

⏱️ Estimated effort to review [1-5]

1, because the change is straightforward and involves updating the license badge image src in the README.md file.

🧪 Relevant tests

No

⚡ Possible issues

No

🔒 Security concerns

No

Copy link
Contributor

penify-dev bot commented Jul 17, 2024

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Accessibility
Improve accessibility by adding descriptive alt text to the license badge image source link

Consider using a more descriptive alt text for the license badge image source link to
improve accessibility.

README.md [237]

-[license-src]: https://img.shields.io/github/license/ChronicStone/typed-xlsx.svg?style=flat&colorA=080f12&colorB=1fa669
+[license-src]: https://img.shields.io/github/license/ChronicStone/typed-xlsx.svg?style=flat&colorA=080f12&colorB=1fa669 alt="License Badge"
 
Suggestion importance[1-10]: 7

Why: Adding descriptive alt text for accessibility is a good practice, but it's a minor improvement that enhances accessibility.

7

@ChronicStone ChronicStone merged commit 556cc52 into ChronicStone:main Jul 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Review effort [1-5]: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants