Skip to content

Add nm_bool to dia_init and add sptype switch to sparse_to_nmatrix and typo fix #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Uditgulati
Copy link
Member

No description provided.

@Uditgulati
Copy link
Member Author

@prasunanand I've changed some elements arrays' data types to void*, so that any type can be assigned to it. This will prevent the nesting of dtpe and sptype switch statements.

Also, I think we can take out some common code in nm_sparse_to_nmatrix and nm_sparse_to_array to a separate function. This will reduce code repetition. What do you think?

@Uditgulati
Copy link
Member Author

@prasunanand void* as function parameter did not work. I found 2 possible solutions to this. One is using an enum structure for types. Second is to make the function as a macro and pass the type.

@prasunanand
Copy link
Member

Please write code and explain in this thread.

@prasunanand
Copy link
Member

keep it on hold, currently.

@Uditgulati
Copy link
Member Author

Part of #21. Closing this one.

@Uditgulati Uditgulati closed this Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants