class NameMungingTest

Same name and namespace in other branches
  1. 8.9.x core/tests/Drupal/KernelTests/Core/File/NameMungingTest.php \Drupal\KernelTests\Core\File\NameMungingTest

Tests filename munging and unmunging.

Checks performed, relying on 2 <= strlen('foo') <= 5.

  • testMunging()

    • (name).foo.txt -> (name).foo_.txt when allows_insecure_uploads === 0
  • testMungeBullByte()
    • (name).foo\0.txt -> (name).foo_.txt regardless of allows_insecure_uploads
  • testMungeIgnoreInsecure()
    • (name).foo.txt unmodified when allows_insecure_uploads === 1
  • testMungeIgnoreAllowedExtensions()
    • (name).FOO.txt -> (name).FOO when allowing 'foo'.
    • (name).foo.txt -> (name).foo.txt when allowing 'FOO'.
  • testMungeUnsafe()
    • (name).php.txt -> (name).php_.txt even when allowing 'php txt'
    • (name).php.txt -> (name).php_.txt even when allowing 'php txt'
  • testUnMunge()
    • (name).foo.txt -> (unchecked) -> (name).foo.txt after un-munging

@group File @group legacy

Hierarchy

Expanded class hierarchy of NameMungingTest

File

core/tests/Drupal/KernelTests/Core/File/NameMungingTest.php, line 30

Namespace

Drupal\KernelTests\Core\File
View source
class NameMungingTest extends FileTestBase {
  
  /**
   * An extension to be used as forbidden during munge operations.
   *
   * @var string
   */
  protected $badExtension;
  
  /**
   * The name of a file with a bad extension, after munging.
   *
   * @var string
   */
  protected $name;
  
  /**
   * The name of a file with an upper-cased bad extension, after munging.
   *
   * @var string
   */
  protected $nameWithUcExt;
  
  /**
   * {@inheritdoc}
   */
  protected function setUp() : void {
    parent::setUp();
    $this->badExtension = 'foo';
    $this->name = $this->randomMachineName() . '.' . $this->badExtension . '.txt';
    $this->nameWithUcExt = $this->randomMachineName() . '.' . strtoupper($this->badExtension) . '.txt';
  }
  
  /**
   * Create a file and munge/unmunge the name.
   */
  public function testMunging() {
    $this->expectDeprecation('file_munge_filename() is deprecated in drupal:9.2.0 and is removed from drupal:10.0.0. Dispatch a \\Drupal\\Core\\File\\Event\\FileUploadSanitizeNameEvent event instead. See https://www.drupal.org/node/3032541');
    // Disable insecure uploads.
    $this->config('system.file')
      ->set('allow_insecure_uploads', 0)
      ->save();
    $munged_name = file_munge_filename($this->name, '', TRUE);
    $messages = \Drupal::messenger()->all();
    \Drupal::messenger()->deleteAll();
    $this->assertContainsEquals(strtr('For security reasons, your upload has been renamed to <em class="placeholder">%filename</em>.', [
      '%filename' => $munged_name,
    ]), $messages['status'], 'Alert properly set when a file is renamed.');
    $this->assertNotEquals($this->name, $munged_name, new FormattableMarkup('The new filename (%munged) has been modified from the original (%original)', [
      '%munged' => $munged_name,
      '%original' => $this->name,
    ]));
  }
  
  /**
   * Tests munging with a null byte in the filename.
   */
  public function testMungeNullByte() {
    $prefix = $this->randomMachineName();
    $filename = $prefix . '.' . $this->badExtension . "\x00.txt";
    $this->assertEquals($prefix . '.' . $this->badExtension . '_.txt', file_munge_filename($filename, ''), 'A filename with a null byte is correctly munged to remove the null byte.');
  }
  
  /**
   * Test munging with system.file.allow_insecure_uploads set to true.
   */
  public function testMungeIgnoreInsecure() {
    $this->config('system.file')
      ->set('allow_insecure_uploads', 1)
      ->save();
    $munged_name = file_munge_filename($this->name, '');
    $this->assertSame($munged_name, $this->name, new FormattableMarkup('The original filename (%original) matches the munged filename (%munged) when insecure uploads are enabled.', [
      '%munged' => $munged_name,
      '%original' => $this->name,
    ]));
  }
  
  /**
   * Tests that allowed extensions are ignored by file_munge_filename().
   */
  public function testMungeIgnoreAllowedExtensions() {
    // Declare that our extension is allowed. The declared extensions should be
    // case insensitive, so test using one with a different case.
    $munged_name = file_munge_filename($this->nameWithUcExt, $this->badExtension);
    $this->assertSame($munged_name, $this->nameWithUcExt);
    // The allowed extensions should also be normalized.
    $munged_name = file_munge_filename($this->name, strtoupper($this->badExtension));
    $this->assertSame($munged_name, $this->name);
  }
  
  /**
   * Tests unsafe extensions are always munged by file_munge_filename().
   */
  public function testMungeUnsafe() {
    $prefix = $this->randomMachineName();
    $name = "{$prefix}.php.txt";
    // Put the php extension in the allowed list, but since it is in the unsafe
    // extension list, it should still be munged.
    $munged_name = file_munge_filename($name, 'php txt');
    $this->assertSame("{$prefix}.php_.txt", $munged_name);
  }
  
  /**
   * Ensure that unmunge gets your name back.
   */
  public function testUnMunge() {
    $this->expectDeprecation('file_unmunge_filename() is deprecated in drupal:9.2.0 and is removed from drupal:10.0.0. Use str_replace() instead. See https://www.drupal.org/node/3032541');
    $munged_name = file_munge_filename($this->name, '', FALSE);
    $unmunged_name = file_unmunge_filename($munged_name);
    $this->assertSame($unmunged_name, $this->name, new FormattableMarkup('The unmunged (%unmunged) filename matches the original (%original)', [
      '%unmunged' => $unmunged_name,
      '%original' => $this->name,
    ]));
  }

}

Buggy or inaccurate documentation? Please file an issue. Need support? Need help programming? Connect with the Drupal community.