[#111472] [Ruby master Bug#19274] Error installing ruby 3.2.0 on RH 8 — "aalllop (Alberto Allegue) via ruby-core" <ruby-core@...>
Issue #19274 has been reported by aalllop (Alberto Allegue).
5 messages
2022/12/28
[#111508] Data support for versions before 3.2.0 — Eustáquio Rangel via ruby-core <ruby-core@...>
I was wondering that every piece of code (gems, etc) that use the new Data =
3 messages
2022/12/29
[ruby-core:111160] [Ruby master Bug#19174] YJIT configure "checking whether rustc works for YJIT... no" in rustc 1.65.0 on x86_64
From:
"alanwu (Alan Wu)" <noreply@...>
Date:
2022-12-02 16:33:02 UTC
List:
ruby-core #111160
Issue #19174 has been updated by alanwu (Alan Wu).
That check is intended for automatically enabling YJIT when we can find a suitable rustc.
When we get --enable-yjit explicitly we listen to that and don't use the result of the check, which is what you're seeing. So it's fine.
That said, it looks like I messed up and assumed that "\n" gives a newline with `echo`. Apparently not in all shells!
----------------------------------------
Bug #19174: YJIT configure "checking whether rustc works for YJIT... no" in rustc 1.65.0 on x86_64
https://bugs.ruby-lang.org/issues/19174#change-100444
* Author: jaruga (Jun Aruga)
* Status: Open
* Priority: Normal
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
On the latest master branch `11871e49c4fe493d6b958046969bc863f7fb6627` on Fedora 36,
```
$ uname -m
x86_64
$ which rustc
/bin/rustc
$ rustc --version
rustc 1.65.0 (Fedora 1.65.0-1.fc37)
```
I am seeing the "checking whether rustc works for YJIT... no".
```
$ ./autogen.sh
$ ./configure --enable-yjit 2>&1 | tee configure.log
...
checking for rustc... rustc
checking whether rustc works for YJIT... no
...
* YJIT support: yes
...
```
Seeing the code <https://github.com/ruby/ruby/blob/11871e49c4fe493d6b958046969bc863f7fb6627/configure.ac#L3744-L3760>, it is to check if the rustc is >= 1.58.0. And the used rustc is 1.65.0.
```
dnl check if rustc is recent enough to build YJIT (rustc >= 1.58.0)
```
I suspect that the checking logic might be something wrong. I checked why the checking logic fails with the modification below.
```
$ git diff
diff --git a/configure.ac b/configure.ac
index 79167a9c67..33a1b9540d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3753,7 +3753,7 @@ AS_IF([test "$RUSTC" != "no"],
dnl Fails in case rustc target doesn't match ruby target.
dnl Can happen on Rosetta, for example.
AS_IF([echo "#[cfg(target_arch = \"$YJIT_TARGET_ARCH\")]\n fn main() { let x = 1; format!(\"{x}\"); }" |
- $RUSTC - --emit asm=/dev/null 2>/dev/null],
+ $RUSTC - --emit asm=/dev/null],
[YJIT_RUSTC_OK=yes]
)
AC_MSG_RESULT($YJIT_RUSTC_OK)
```
```
$ ./autogen.sh
$ ./configure --enable-yjit 2>&1 | tee configure_debug.log
...
checking for rustc... rustc
checking whether rustc works for YJIT... error: unknown start of token: \
--> <anon>:1:31
|
1 | #[cfg(target_arch = "x86_64")]\n fn main() { let x = 1; format!("{x}"); }
| ^
error: expected one of `!` or `::`, found keyword `fn`
--> <anon>:1:34
|
1 | #[cfg(target_arch = "x86_64")]\n fn main() { let x = 1; format!("{x}"); }
| ^^ expected one of `!` or `::`
error: aborting due to 2 previous errors
no
...
* YJIT support: yes
...
```
Is it intended behavior? Actually after running the `configure`, the `make` works.
--
https://bugs.ruby-lang.org/
______________________________________________
ruby-core mailing list -- [email protected]
To unsubscribe send an email to [email protected]
ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/