ruby-core

Issue #20412 has been updated by etienne (=C9tienne Barri=E9).


Hey,

I cannot reproduce using the ruby:3.2.3 docker image and with my local inst=
allation of Ruby 3.2.3 and 3.2.2.

In all these cases, I get "OK" "is not valid UTF-8". I just changed the scr=
ipt to always use size 1 and bundler/inline:

```ruby
# encoding: ASCII-8BIT
# frozen_string_literal: false

require "bundler/inline"

gemfile(true) do
  source "https://rubygems.org"
  gem "rbnacl"
end

p "RUBY: #{RUBY_VERSION}"
require 'rbnacl'

class Encrypter
  extend RbNaCl::Sodium

  sodium_type :stream

  sodium_primitive :xchacha20

  sodium_function :stream_xchacha20_xor,
                  :crypto_stream_xchacha20_xor,
                  %i[pointer pointer ulong_long pointer pointer]

  attr_reader :key

  def initialize(key)
    @key =3D key
  end

  def encrypt_with_rbnacl_buffer(nonce, message)
    c =3D RbNaCl::Util.zeros(message.bytesize)
    self.class.stream_xchacha20_xor(c, message, message.bytesize, nonce, ke=
y)
    c
  end

  def encrypt_with_local_buffer(nonce, message)
    c =3D "\0" * message.bytesize
    self.class.stream_xchacha20_xor(c, message, message.bytesize, nonce, ke=
y)
    c
  end
end

begin
  "\xC0".encode('UTF-8')
  p 'FAIL: plaintext is not valid UTF-8 and did not error during encoding t=
o UTF-8'
rescue StandardError
end

SIZE =3D 1

input =3D ("\xC0" * SIZE) + ' '
nonce =3D 'B' * 24
key =3D 'A' * 32

enc =3D Encrypter.new(key)

ciphertext_rbnacl =3D enc.encrypt_with_rbnacl_buffer(nonce, input)
ciphertext_local =3D enc.encrypt_with_local_buffer(nonce, input)

plaintext_rbnacl =3D enc.encrypt_with_rbnacl_buffer(nonce, ciphertext_rbnac=
l)
plaintext_local =3D enc.encrypt_with_local_buffer(nonce, ciphertext_local)

begin
  input.encode('UTF-8')
  p 'FAIL: input is not valid UTF-8 and did not error during encoding to UT=
F-8'
rescue Encoding::UndefinedConversionError
end

begin
  ciphertext_rbnacl.encode('UTF-8')
  p 'FAIL: ciphertext_rbnacl is not valid UTF-8 and did not error during en=
coding to UTF-8'
rescue Encoding::UndefinedConversionError
  p 'OK: ciphertext_rbnacl is not valid UTF-8'
end

begin
  ciphertext_local.encode('UTF-8')
  p 'FAIL: ciphertext_local is not valid UTF-8 and did not error during enc=
oding to UTF-8'
rescue Encoding::UndefinedConversionError
  p 'OK: ciphertext_local is not valid UTF-8'
end

begin
  plaintext_rbnacl.encode('UTF-8')
  p 'FAIL: plaintext_rbnacl is not valid UTF-8 and did not error during enc=
oding to UTF-8'
rescue Encoding::UndefinedConversionError
  p 'OK: plaintext_rbnacl is not valid UTF-8'
end

begin
  plaintext_local.encode('UTF-8')
  p 'FAIL: plaintext_local is not valid UTF-8 and did not error during enco=
ding to UTF-8'
rescue Encoding::UndefinedConversionError
  p 'OK: plaintext_local is not valid UTF-8'
end
```

Which version of libsodium are you using? Perhaps some specific version mut=
ates a char * string?

----------------------------------------
Bug #20412: UTF-8 String encoding behavior differs between 3.2, 3.3 and mas=
ter
https://bugs.ruby-lang.org/issues/20412#change-107853

* Author: bannable (Joe Truba)
* Status: Open
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN
----------------------------------------
When a String that contains only a `\0` byte is mutated by an extension to =
an invalid UTF-8 sequence, calling `.encode('UTF-8')` does not consistently=
 raise `UndefinedConversionError` across ruby versions. When the string is =
longer than 1 byte, all versions I've tested correctly raise `UndefinedConv=
ersionError`.

For Ruby 3.2, `UndefinedConversionError` being raised appears to depend on =
where the string was originally allocated.

For Ruby 3.3, `UndefinedConversionError` is never raised.

For master ad90fdd24c, `UndefinedConversionError` is always correctly raise=
d.

I haven't been able to find a bug for this, but it seems like there is a fi=
x in master that should be backported to at least 3.2 and 3.3.

I have not tested 3.1.

The attached reproducer depends on `rbnacl` because it is minimized from a =
cryptographic project, and I wasn't able to reduce it further.

## Expected Output

For all versions:
```
$ ruby repro.rb 1
"RUBY: [version]"
"OK: ciphertext_rbnacl is not valid UTF-8"
"OK: ciphertext_local is not valid UTF-8"
"OK: plaintext_rbnacl is not valid UTF-8"
"OK: plaintext_local is not valid UTF-8"

$ ruby repro.rb 2
"RUBY: [version]"
"OK: ciphertext_rbnacl is not valid UTF-8"
"OK: ciphertext_local is not valid UTF-8"
"OK: plaintext_rbnacl is not valid UTF-8"
"OK: plaintext_local is not valid UTF-8"
```

## Actual Output

### Ruby 3.2
```
$ ASDF_RUBY_VERSION=3D3.2.3 ruby -v; ASDF_RUBY_VERSION=3D3.2.3 ruby repro.r=
b 1
ruby 3.2.3 (2024-01-18 revision 52bb2ac0a6) [x86_64-linux]
"RUBY: 3.2.3"
"OK: ciphertext_rbnacl is not valid UTF-8"
"FAIL: ciphertext_local is not valid UTF-8 and did not error during encodin=
g to UTF-8"
"OK: plaintext_rbnacl is not valid UTF-8"
"FAIL: plaintext_local is not valid UTF-8 and did not error during encoding=
 to UTF-8"

$ ASDF_RUBY_VERSION=3D3.2.3 ruby -v; ASDF_RUBY_VERSION=3D3.2.3 ruby repro.r=
b 2
ruby 3.2.3 (2024-01-18 revision 52bb2ac0a6) [x86_64-linux]
"RUBY: 3.2.3"
"OK: ciphertext_rbnacl is not valid UTF-8"
"OK: ciphertext_local is not valid UTF-8"
"OK: plaintext_rbnacl is not valid UTF-8"
"OK: plaintext_local is not valid UTF-8"
```

### Ruby 3.3
```
$ ASDF_RUBY_VERSION=3D3.3.0 ruby -v; ASDF_RUBY_VERSION=3D3.3.0 ruby repro.r=
b 1
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-linux]
"RUBY: 3.3.0"
"FAIL: ciphertext_rbnacl is not valid UTF-8 and did not error during encodi=
ng to UTF-8"
"FAIL: ciphertext_local is not valid UTF-8 and did not error during encodin=
g to UTF-8"
"FAIL: plaintext_rbnacl is not valid UTF-8 and did not error during encodin=
g to UTF-8"
"FAIL: plaintext_local is not valid UTF-8 and did not error during encoding=
 to UTF-8"

$ ASDF_RUBY_VERSION=3D3.3.0 ruby -v; ASDF_RUBY_VERSION=3D3.3.0 ruby repro.r=
b 2
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-linux]
"RUBY: 3.3.0"
"OK: ciphertext_rbnacl is not valid UTF-8"
"OK: ciphertext_local is not valid UTF-8"
"OK: plaintext_rbnacl is not valid UTF-8"
"OK: plaintext_local is not valid UTF-8"
```

### Ruby Master
```
$ ASDF_RUBY_VERSION=3Druby-dev ruby -v; ASDF_RUBY_VERSION=3Druby-dev ruby r=
epro.rb 1
ruby 3.4.0dev (2024-04-06T17:33:16Z master ad90fdd24c) [x86_64-linux]
"RUBY: 3.4.0"
"OK: ciphertext_rbnacl is not valid UTF-8"
"OK: ciphertext_local is not valid UTF-8"
"OK: plaintext_rbnacl is not valid UTF-8"
"OK: plaintext_local is not valid UTF-8"

$ ASDF_RUBY_VERSION=3Druby-dev ruby -v; ASDF_RUBY_VERSION=3Druby-dev ruby r=
epro.rb 2
ruby 3.4.0dev (2024-04-06T17:33:16Z master ad90fdd24c) [x86_64-linux]
"RUBY: 3.4.0"
"OK: ciphertext_rbnacl is not valid UTF-8"
"OK: ciphertext_local is not valid UTF-8"
"OK: plaintext_rbnacl is not valid UTF-8"
"OK: plaintext_local is not valid UTF-8"
```

---Files--------------------------------
repro.rb (2.31 KB)


--=20
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- [email protected]
 To unsubscribe send an email to [email protected]
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-c=
ore.ml.ruby-lang.org/

Thread

Prev Next

In This Thread

Prev Next