[#71815] [Ruby trunk - Bug #11768] [Open] Add a polymorphic inline cache — tenderlove@...
Issue #11768 has been reported by Aaron Patterson.
6 messages
2015/12/03
[#71819] Re: [Ruby trunk - Bug #11768] [Open] Add a polymorphic inline cache
— Eric Wong <normalperson@...>
2015/12/03
[email protected] wrote:
[#71821] Re: [Ruby trunk - Bug #11768] [Open] Add a polymorphic inline cache
— Aaron Patterson <tenderlove@...>
2015/12/03
On Thu, Dec 03, 2015 at 10:51:08PM +0000, Eric Wong wrote:
[#71824] Re: [Ruby trunk - Bug #11768] [Open] Add a polymorphic inline cache
— Eric Wong <normalperson@...>
2015/12/04
Aaron Patterson <[email protected]> wrote:
[#71818] [Ruby trunk - Feature #11769] [Open] optimize case / when for `nil` — tenderlove@...
Issue #11769 has been reported by Aaron Patterson.
4 messages
2015/12/03
[#71825] Re: [Ruby trunk - Feature #11769] [Open] optimize case / when for `nil`
— Eric Wong <normalperson@...>
2015/12/04
[email protected] wrote:
[#71931] [Ruby trunk - Feature #11786] [Open] [PATCH] micro-optimize case dispatch even harder — normalperson@...
Issue #11786 has been reported by Eric Wong.
9 messages
2015/12/08
[#71932] Re: [Ruby trunk - Feature #11786] [Open] [PATCH] micro-optimize case dispatch even harder
— Eric Wong <normalperson@...>
2015/12/08
Oops, I forgot to free the table when iseq is destroyed :x
[#71934] Re: [Ruby trunk - Feature #11786] [Open] [PATCH] micro-optimize case dispatch even harder
— SASADA Koichi <ko1@...>
2015/12/08
On 2015/12/08 12:43, Eric Wong wrote:
[#71936] Re: [Ruby trunk - Feature #11786] [Open] [PATCH] micro-optimize case dispatch even harder
— Eric Wong <normalperson@...>
2015/12/08
SASADA Koichi <[email protected]> wrote:
[#71938] Re: [Ruby trunk - Feature #11786] [Open] [PATCH] micro-optimize case dispatch even harder
— SASADA Koichi <ko1@...>
2015/12/08
On 2015/12/08 13:53, Eric Wong wrote:
[#72028] [Ruby trunk - Feature #11405] [Assigned] [PATCH] hash.c: minor speedups to int/fixnum keys — mame@...
Issue #11405 has been updated by Yusuke Endoh.
5 messages
2015/12/10
[#72040] Re: [Ruby trunk - Feature #11405] [Assigned] [PATCH] hash.c: minor speedups to int/fixnum keys
— Eric Wong <normalperson@...>
2015/12/10
[email protected] wrote:
[#72045] Ruby 2.3.0-preview2 Released — "NARUSE, Yui" <naruse@...>
We are pleased to announce the release of Ruby 2.3.0-preview2.
10 messages
2015/12/11
[#72047] Re: Ruby 2.3.0-preview2 Released
— SASADA Koichi <ko1@...>
2015/12/11
Please add your optimizations before RC1.
[#72054] Re: Ruby 2.3.0-preview2 Released
— Eric Wong <normalperson@...>
2015/12/11
SASADA Koichi <[email protected]> wrote:
[#72436] Re: Ruby 2.3.0-preview2 Released
— SASADA Koichi <ko1@...>
2015/12/22
On 2015/12/11 18:06, Eric Wong wrote:
[#72440] Re: Ruby 2.3.0-preview2 Released
— Eric Wong <normalperson@...>
2015/12/22
SASADA Koichi <[email protected]> wrote:
[#72069] [Ruby trunk - Feature #11405] [PATCH] hash.c: minor speedups to int/fixnum keys — mame@...
Issue #11405 has been updated by Yusuke Endoh.
3 messages
2015/12/12
[#72115] Re: [ruby-cvs:60264] duerst:r53112 (trunk): * enc/ebcdic.h: new dummy encoding EBCDIC-US — "U.NAKAMURA" <usa@...>
Hi,
7 messages
2015/12/14
[#72124] Re: [ruby-cvs:60264] duerst:r53112 (trunk): * enc/ebcdic.h: new dummy encoding EBCDIC-US
— Martin J. Dürst <duerst@...>
2015/12/14
On 2015/12/14 22:34, U.NAKAMURA wrote:
[#72125] Re: [ruby-cvs:60264] duerst:r53112 (trunk): * enc/ebcdic.h: new dummy encoding EBCDIC-US
— "U.NAKAMURA" <usa@...>
2015/12/15
Hi,
[ruby-core:72169] [Ruby trunk - Feature #11708] Specify a way to override Struct-subclass constructor
From:
ruby-core@...
Date:
2015-12-16 03:23:19 UTC
List:
ruby-core #72169
Issue #11708 has been updated by Marc-Andre Lafortune.
It's true that there is no test (and more surprisingly no Rubyspec) on this.
I'm not Matz either, but I feel there's no way that this behavior will ever change. First because there's no reason why it would, but more importantly because it would be a source of incompatibility and frustration.
I feel you can deduce that `initialize` is overridable from the current doc, as it states that `Struct.new do ... end` is preferred to subclassing. If `Struct.new` was defining an `initialize` (and thus preventing easy overriding of initialize), then there would be a caveat since subclassing would not have this problem.
I added a test and hope this will resolve conclusively this issue.
----------------------------------------
Feature #11708: Specify a way to override Struct-subclass constructor
https://bugs.ruby-lang.org/issues/11708#change-55580
* Author: Ilya Vorontsov
* Status: Open
* Priority: Normal
* Assignee: Yukihiro Matsumoto
----------------------------------------
It's common to create simple data-object with some constraints. One can either implement custom class or use `Struct`. Struct is generally simpler and helps to avoid some mistakes as non-defined `#hash` and `#eql?`. But at the same time it's more difficult to make validation for `Struct` subclass.
```ruby
Point = Struct.new(:x, :y)
NonnegativePoint = Struct.new(:x,:y) do
def initialize(*args, &block)
super
raise 'Negative coordinates are not allowed' if x < 0 || y < 0
end
end
```
Above written code solves the problem but has one flaw. `Struct.new` creates a subclass of `Struct` and defines some methods as `#x`, `#x=`. And there are no guarantees that `NonnegativePoint#initialize` wasn't redefined too.
We can check that `Point.new` without explicitly defined `#initialize` actually hits `Struct#initialize` and `Point#initialize` not defined:
```ruby
Point.instance_method(:initialize)
# => #<UnboundMethod: Point(Struct)#initialize>
NonnegativePoint.instance_method(:initialize)
# => #<UnboundMethod: NonnegativePoint#initialize>
```
But nothing in `Struct` documentation or test suite states that this behavior can't be changed in newer ruby versions.
I propose either to declare in docs and test that initialize method can be safely overriden because `#initialize` is not defined in `Struct` subclasses.
In you assume that one day current behavior can change (e.g. for perfomance reasons), then it's reasonable to create an extension point like '#after_initialize' which is called from `Struct`'s subclass `#initialize` method.
--
https://bugs.ruby-lang.org/