[ruby-core:95924] [Ruby master Bug#16361] TestEnv#test_fetch failure
From:
mame@...
Date:
2019-11-24 14:08:04 UTC
List:
ruby-core #95924
Issue #16361 has been updated by mame (Yusuke Endoh).
I cannot reproduce the issue with ruby 2.7.0-preview3.
```
$ make test-all TESTS=test/ruby/test_env.rb
fatal: not a git repository (or any of the parent directories): .git
./revision.h unchanged
config.status: creating ruby-runner.h
making mjit_build_dir.so
Run options: "--ruby=./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems" --excludes-dir=./test/excludes --name=!/memory_leak/
# Running tests:
Finished tests in 0.026560s, 1618.9994 tests/s, 40889.1485 assertions/s.
43 tests, 1086 assertions, 0 failures, 0 errors, 0 skips
ruby -v: ruby 2.7.0preview3 (2019-11-22 master 35608760ff) [x86_64-linux]
```
Could you elaborate on what you did?
----------------------------------------
Bug #16361: TestEnv#test_fetch failure
https://bugs.ruby-lang.org/issues/16361#change-82764
* Author: vo.x (Vit Ondruch)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v: ruby 2.7.0dev (2019-11-22 master f9d20a1bf1) [x86_64-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
I am facing following test suite error:
~~~
1) Failure:
TestEnv#test_fetch [/builddir/build/BUILD/ruby-2.7.0-f9d20a1bf1/test/ruby/test_env.rb:123]:
[ruby-core:56062] [Feature #8649].
Expected Exception(KeyError) was raised, but the message doesn't match.
<"key not found: \"test\""> expected but was
<"key not found: \"test\"\n" + "Did you mean? \"TESTS\"">.
~~~
Trying to execute this test independently, it passes just fine. So it seems that the did_you_mean gem is loaded unexpectedly on this place. I just tried:
~~~
mv test/optparse/test_did_you_mean.rb{,.bak}
~~~
since this is the latest addition IMO and the test suite passes just fine.
I am not really sure why it should fail on my setup and it probably does not fail in any other CI. Neither I am sure what would be the best option to fix this. The assertion could be updated to accept this message by simple sed:
~~~
sed -i "/'key not found: \"test\"'/ s/'/\//g" test/ruby/test_env.rb
~~~
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>